Revert #211 "OCPCLOUD-2277: Ensure Cluster Machine Approver metrics are only available via HTTPS" #216
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@neisw: This pull request references OCPCLOUD-2277 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Staging the revert in case the fix on the hypershift end doesn't fix it |
openshift-ci
bot
added
the
do-not-merge/hold
|
@neisw: This pull request references OCPCLOUD-2277 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@neisw: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@DennisPeriquet @neisw Is this still needed? We merged this after clearing it with HyperShift and then they realised that it broke them. My understanding is that they then raised a quick fix and things should be back to green, so, we shouldn't need a revert. CC @enxebre |
|
@JoelSpeed - Correct openshift/hypershift#3227 merged and CI is good again. /close |
|
@neisw: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reverts #211 ; tracked by OCPBUGS-23737
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
Hypershift e2e failed in 4.15.0-0.ci-2023-11-22-141748 - Hypershift team acknowledges they need to remove the probe. Staging the revert for now in case they don't get it worked out quickly.
To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:
CC: @racheljpg