Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2417: Update to kube 1.29 and controller-runtime 0.17.0 #224

Merged
merged 1 commit into from Jan 19, 2024

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Jan 17, 2024

In addition to updating the libraries, this PR:

  • Removed deprecated use of client.NewDelegatingClient
  • Fixed missing logging argument
  • Updated function signature to match new definition

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 17, 2024

@nrb: This pull request references OCPCLOUD-2417 which is a valid jira issue.

In response to this:

In addition to updating the libraries, this PR:

  • Removed deprecated use of client.NewDelegatingClient
  • Fixed missing logging argument
  • Updated function signature to match new definition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2024
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2024
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

@nrb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8e17bc2 into openshift:master Jan 19, 2024
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-machine-approver-container-v4.16.0-202401200231.p0.g8e17bc2.assembly.stream for distgit ose-cluster-machine-approver.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants