fix: fix wrong test

Signed-off-by: Mario Fernandez <mariofer@redhat.com>
openshift · Oct 20, 2023 · 64a2309 · 64a2309
1 parent 3ab03f5
commit 64a2309
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/assets/prometheus-user-workload/alertmanager-user-workload-role-binding.yaml b/assets/prometheus-user-workload/alertmanager-user-workload-role-binding.yaml
@@ -12,5 +12,5 @@ roleRef:
   name: monitoring-alertmanager-api-writer
 subjects:
 - kind: ServiceAccount
-  name: prometheus-user-workload 
+  name: prometheus-user-workload
   namespace: openshift-user-workload-monitoring
diff --git a/jsonnet/components/prometheus-user-workload.libsonnet b/jsonnet/components/prometheus-user-workload.libsonnet
@@ -189,7 +189,7 @@ function(params)
       },
       subjects: [{
         kind: 'ServiceAccount',
-        name: cfg.name,
+        name: 'prometheus-' + cfg.name,
         namespace: cfg.namespace,
       }],
     },

diff --git a/test/e2e/alertmanager_user_workload_test.go b/test/e2e/alertmanager_user_workload_test.go
@@ -89,7 +89,7 @@ func assertUWMAlertsAccess(t *testing.T) {
 	client := framework.NewPrometheusClient(host, token)
 
 	err = framework.Poll(5*time.Second, time.Minute, func() error {
-		resp, err := client.Do("GET", "/api/v2/rules", nil)
+		resp, err := client.Do("GET", "/api/v2/alerts", nil)
 		if err != nil {
 			return err
 		}
@@ -100,7 +100,7 @@ func assertUWMAlertsAccess(t *testing.T) {
 			return err
 		}
 
-		if resp.StatusCode == http.StatusOK {
+		if resp.StatusCode != http.StatusForbidden {
 			return fmt.Errorf("unexpected status code response, want different of %d, (%s)", http.StatusOK, framework.ClampMax(b))
 		}
 		return nil