pkg/client: invert CRB checks

openshift · Sep 17, 2020 · aa7b164 · aa7b164
1 parent 16813f9
commit aa7b164
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/pkg/client/client.go b/pkg/client/client.go
@@ -1102,11 +1102,9 @@ func (c *Client) CreateOrUpdateClusterRoleBinding(crb *rbacv1.ClusterRoleBinding
 		return errors.Wrap(err, "retrieving ClusterRoleBinding object failed")
 	}
 
-	changed := reflect.DeepEqual(crb.RoleRef, existing.RoleRef)
-	changed = changed || reflect.DeepEqual(crb.Subjects, existing.Subjects)
-	changed = changed || reflect.DeepEqual(crb.Labels, existing.Labels)
-
-	if !changed {
+	if reflect.DeepEqual(crb.RoleRef, existing.RoleRef) &&
+		reflect.DeepEqual(crb.Subjects, existing.Subjects) &&
+		reflect.DeepEqual(crb.Labels, existing.Labels) {
 		return nil
 	}