Skip to content

Commit

Permalink
Bug 1860889: increase QPS and burst settings for clients
Browse files Browse the repository at this point in the history
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
  • Loading branch information
simonpasquier committed Aug 24, 2020
1 parent fbcb670 commit c65de50
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 1 addition & 2 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
component: "Monitoring"

reviewers:
- brancz
- s-urbaniak
- paulfantom
- LiliC
- pgier
- simonpasquier

approvers:
- brancz
- bparees
- s-urbaniak
- paulfantom
Expand All @@ -18,5 +16,6 @@ approvers:
- simonpasquier

emeritus_approvers:
- brancz
- squat
- metalmatze
4 changes: 4 additions & 0 deletions cmd/operator/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ func Main() int {
return 1
}

// CMO runs many tasks in parallel and the default values for rate limiting are too low.
config.QPS = 20
config.Burst = 50

userWorkloadConfigMapName := "user-workload-monitoring-config"
o, err := cmo.New(config, *releaseVersion, *namespace, *namespaceUserWorkload, *namespaceSelector, *configMapName, userWorkloadConfigMapName, *remoteWrite, images.asMap(), telemetryConfig.Matches)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ func (c *Client) WaitForDeploymentRollout(dep *appsv1.Deployment) error {
}
if d.Status.UnavailableReplicas != 0 {
lastErr = errors.Errorf("got %d unavailable replicas",
d.Status.UpdatedReplicas)
d.Status.UnavailableReplicas)
return false, nil
}
return true, nil
Expand Down

0 comments on commit c65de50

Please sign in to comment.