test/e2e/framework: fix closing of HTTP requests

openshift · Mar 26, 2020 · f4f37b3 · f4f37b3
1 parent fcd53e5
commit f4f37b3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/test/e2e/framework/route_client.go b/test/e2e/framework/route_client.go
@@ -105,6 +105,7 @@ func (c *RouteClient) PrometheusQuery(query string) ([]byte, error) {
 	if err != nil {
 		return nil, err
 	}
+	defer resp.Body.Close()
 
 	if resp.StatusCode != http.StatusOK {
 		return nil, fmt.Errorf("unexpected status code response, want %d, got %d", http.StatusOK, resp.StatusCode)
@@ -145,13 +146,12 @@ func (c *RouteClient) AlertmanagerQuery(kvs ...string) ([]byte, error) {
 	if err != nil {
 		return nil, err
 	}
+	defer resp.Body.Close()
 
 	if resp.StatusCode != http.StatusOK {
 		return nil, fmt.Errorf("unexpected status code response, want %d, got %d", http.StatusOK, resp.StatusCode)
 	}
 
-	defer resp.Body.Close()
-
 	body, err := ioutil.ReadAll(resp.Body)
 	if err != nil {
 		return nil, err