[release-4.6] Bug 1904091: Exporting registry v1 protocol usage metric #1002

ricardomaraschini · 2020-12-03T14:25:17Z

Due to merge conflicts, this is a verbatim copy of #949

This PR exports the sum of v1_image_imports_total metric. We use this
metric to count the number of image streams imported using registry
v1 as we are planning to deprecate this version soon.

This PR exports v1_image_imports_total metric. We use this metric to
count the number of image streams imported using registry v1 as we are
planning to deprecate this version soon.

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

This PR exports the sum of v1_image_imports_total metric. We use this metric to count the number of image streams imported using registry v1 as we are planning to deprecate this version soon.

openshift-ci-robot · 2020-12-03T14:25:22Z

@ricardomaraschini: This pull request references Bugzilla bug 1904091, which is invalid:

expected dependent Bugzilla bug 1885856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-12-03T14:25:33Z

@ricardomaraschini: This pull request references Bugzilla bug 1904091, which is invalid:

expected dependent Bugzilla bug 1885856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lilic · 2020-12-04T08:17:46Z

/retest

lilic

/lgtm

openshift-bot · 2020-12-04T10:11:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-04T11:42:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-04T13:39:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-04T15:36:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-04T20:09:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-04T20:48:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-04T23:24:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-05T00:03:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-05T01:02:27Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-05T01:02:30Z

@openshift-bot: This pull request references Bugzilla bug 1904091, which is invalid:

expected dependent Bugzilla bug 1885856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-05T07:25:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-05T13:41:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T01:01:27Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-06T01:01:30Z

@openshift-bot: This pull request references Bugzilla bug 1904091, which is invalid:

expected dependent Bugzilla bug 1885856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-07T01:00:53Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-07T01:00:56Z

@openshift-bot: This pull request references Bugzilla bug 1904091, which is invalid:

expected dependent Bugzilla bug 1885856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-08T01:00:46Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-08T01:00:49Z

@openshift-bot: This pull request references Bugzilla bug 1904091, which is invalid:

expected dependent Bugzilla bug 1885856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-13T01:01:05Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-13T01:01:09Z

@openshift-bot: This pull request references Bugzilla bug 1904091, which is invalid:

expected dependent Bugzilla bug 1885856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-14T01:01:06Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-14T01:01:09Z

@openshift-bot: This pull request references Bugzilla bug 1904091, which is invalid:

expected dependent Bugzilla bug 1885856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-15T01:01:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-15T01:01:18Z

@openshift-bot: This pull request references Bugzilla bug 1904091, which is invalid:

expected dependent Bugzilla bug 1885856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-16T01:00:33Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-16T01:00:39Z

@openshift-bot: This pull request references Bugzilla bug 1904091, which is invalid:

expected dependent Bugzilla bug 1885856 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-17T01:01:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-17T01:01:22Z

@openshift-bot: This pull request references Bugzilla bug 1904091, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1885856 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1885856 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wzheng1 · 2021-01-22T06:54:46Z

/label qe-approved
$ oc -n openshift-monitoring get cm telemetry-config -o jsonpath="{.data.metrics.yaml}" | grep apiserver_v1_image_imports:sum

(image-registry-team) :apiserver_v1_image_imports:sum counts the number of image stream

'{name=":apiserver_v1_image_imports:sum"}'

openshift-ci-robot · 2021-01-22T06:56:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, ricardomaraschini, wzheng1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lilic]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-01-27T20:24:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T04:13:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T05:31:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T07:28:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T09:38:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T10:04:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T11:35:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T14:50:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T15:16:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T15:29:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T17:13:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T17:26:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-01-28T19:25:34Z

@ricardomaraschini: All pull requests linked via external trackers have merged:

Bugzilla bug 1904091 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Exporting registry v1 protocol usage metric

01c0dc4

This PR exports the sum of v1_image_imports_total metric. We use this metric to count the number of image streams imported using registry v1 as we are planning to deprecate this version soon.

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 3, 2020

openshift-ci-robot requested review from lilic and s-urbaniak December 3, 2020 14:25

lilic reviewed Dec 4, 2020

View reviewed changes

openshift-ci-robot assigned lilic Dec 4, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 17, 2020

jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 27, 2021

openshift-ci-robot mentioned this pull request Jan 27, 2021

[release-4.6] Bug 1904091: Creating prometheus record rule for v1 imports openshift/cluster-image-registry-operator#646

Merged

openshift-merge-robot merged commit 12c8d86 into openshift:release-4.6 Jan 28, 2021

[release-4.6] Bug 1904091: Exporting registry v1 protocol usage metric #1002

[release-4.6] Bug 1904091: Exporting registry v1 protocol usage metric #1002

Conversation

ricardomaraschini commented Dec 3, 2020 • edited

openshift-ci-robot commented Dec 3, 2020

openshift-ci-robot commented Dec 3, 2020

lilic commented Dec 4, 2020

lilic left a comment

Choose a reason for hiding this comment

openshift-bot commented Dec 4, 2020

openshift-bot commented Dec 4, 2020

openshift-bot commented Dec 4, 2020

openshift-bot commented Dec 4, 2020

openshift-bot commented Dec 4, 2020

openshift-bot commented Dec 4, 2020

openshift-bot commented Dec 4, 2020

openshift-bot commented Dec 5, 2020

openshift-bot commented Dec 5, 2020

openshift-ci-robot commented Dec 5, 2020

openshift-bot commented Dec 5, 2020

openshift-bot commented Dec 5, 2020

openshift-bot commented Dec 6, 2020

openshift-ci-robot commented Dec 6, 2020

openshift-bot commented Dec 7, 2020

openshift-ci-robot commented Dec 7, 2020

openshift-bot commented Dec 8, 2020

openshift-ci-robot commented Dec 8, 2020

openshift-bot commented Dec 13, 2020

openshift-ci-robot commented Dec 13, 2020

openshift-bot commented Dec 14, 2020

openshift-ci-robot commented Dec 14, 2020

openshift-bot commented Dec 15, 2020

openshift-ci-robot commented Dec 15, 2020

openshift-bot commented Dec 16, 2020

openshift-ci-robot commented Dec 16, 2020

openshift-bot commented Dec 17, 2020

openshift-ci-robot commented Dec 17, 2020

wzheng1 commented Jan 22, 2021 • edited

(image-registry-team) :apiserver_v1_image_imports:sum counts the number of image stream

openshift-ci-robot commented Jan 22, 2021

openshift-bot commented Jan 27, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-ci-robot commented Jan 28, 2021

ricardomaraschini commented Dec 3, 2020 •

edited

wzheng1 commented Jan 22, 2021 •

edited