Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1959278: Remove obsolete user-workload ServiceMonitor #1166

Merged
merged 1 commit into from May 19, 2021
Merged

Bug 1959278: Remove obsolete user-workload ServiceMonitor #1166

merged 1 commit into from May 19, 2021

Conversation

bison
Copy link
Contributor

@bison bison commented May 18, 2021

The ServiceMonitor for the user-workload Prometheus instance was
renamed from prometheus to prometheus-user-workload in #1044. The
old ServiceMonitor should be removed now.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1959278

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2021

@bison: This pull request references Bugzilla bug 1959278, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

WIP: Bug 1959278: Remove obsolete user-workload ServiceMonitor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2021
@openshift-ci openshift-ci bot requested review from jan--f and s-urbaniak May 18, 2021 10:47
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@bison
Copy link
Contributor Author

bison commented May 18, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2021

@bison: This pull request references Bugzilla bug 1959278, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2021
@openshift-ci openshift-ci bot requested a review from juzhao May 18, 2021 10:49
@bison
pkg/tasks: Remove obsolete user-workload ServiceMonitor
cf1cf29 
The ServiceMonitor for the user-workload Prometheus instance was
renamed from `prometheus` to `prometheus-user-workload` in openshift#1044.  The
old ServiceMonitor should be removed now.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1959278
@bison bison changed the title WIP: Bug 1959278: Remove obsolete user-workload ServiceMonitor Bug 1959278: Remove obsolete user-workload ServiceMonitor May 18, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2021
@bison
Copy link
Contributor Author

bison commented May 19, 2021

/retest

@dgrisonnet
Copy link
Member

/lgtm

@dgrisonnet
Copy link
Member

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison, dgrisonnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2bcf477 into openshift:master May 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2021

@bison: All pull requests linked via external trackers have merged:

Bugzilla bug 1959278 has been moved to the MODIFIED state.

In response to this:

Bug 1959278: Remove obsolete user-workload ServiceMonitor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bison bison deleted the BZ-1959278 branch May 20, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bison @dgrisonnet @openshift-bot @openshift-merge-robot