New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1955464: drop container_memory_failures_total metric backport #1180
Bug 1955464: drop container_memory_failures_total metric backport #1180
Conversation
slashpai
commented
May 25, 2021
- I added CHANGELOG entry for this change.
- No user facing changes, so no entry in CHANGELOG was needed.
Signed-off-by: Jayapriya Pai <janantha@redhat.com>
@slashpai: This pull request references Bugzilla bug 1955464, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @simonpasquier |
you need to run |
Ran make command to regenerate manifests |
/retest |
@simonpasquier It is fixed now. Can you review? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonpasquier, slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@slashpai: All pull requests linked via external trackers have merged: Bugzilla bug 1955464 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |