Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1955483: [4.6] Drop high-cardinality metrics from kube-state-metrics which aren't used #1220

Closed
wants to merge 3 commits into from
Closed

Bug 1955483: [4.6] Drop high-cardinality metrics from kube-state-metrics which aren't used #1220

wants to merge 3 commits into from

Conversation

arajkumar
Copy link
Contributor

Cherry-picked #1141 and #1163

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

simonpasquier and others added 3 commits June 15, 2021 17:33
@simonpasquier @arajkumar
jsonnet: don't expose KSM metrics with excessive cardinality
c9bddf2 
Some metrics exposed by kube-state-metrics have high cardinality and
they aren't used in any alerting/recording rule or dashboard.

This patch is based on this upstream kube-prometheus pull request:
prometheus-operator/kube-prometheus#1076

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier @arajkumar
jsonnet: fix KSM regex patterns
492f960
@arajkumar
assets: regenerate
d236696 
Signed-off-by: Arunprasad Rajkumar <arajkuma@redhat.com>
@openshift-ci openshift-ci bot requested review from bison and paulfantom June 15, 2021 12:16
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arajkumar
To complete the pull request process, please assign dgrisonnet after the PR has been reviewed.
You can assign the PR to them by writing /assign @dgrisonnet in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arajkumar arajkumar changed the base branch from master to release-4.6 June 15, 2021 12:16
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@arajkumar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 1955483 - [4.6] Drop high-cardinality metrics from kube-state-metrics which aren't used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021 •
edited

@arajkumar: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-upgrade d236696 link /test e2e-agnostic-upgrade
ci/prow/e2e-agnostic-operator d236696 link /test e2e-agnostic-operator
ci/prow/jsonnet-fmt d236696 link /test jsonnet-fmt
ci/prow/rules d236696 link /test rules
ci/prow/e2e-aws-single-node d236696 link /test e2e-aws-single-node
ci/prow/e2e-agnostic d236696 link /test e2e-agnostic

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@arajkumar
Copy link
Contributor Author

/retest

@arajkumar arajkumar changed the title Bug 1955483 - [4.6] Drop high-cardinality metrics from kube-state-metrics which aren't used Bug 1955483: [4.6] Drop high-cardinality metrics from kube-state-metrics which aren't used Jun 15, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@arajkumar: This pull request references Bugzilla bug 1955483, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1955482 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1955482 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

Bug 1955483: [4.6] Drop high-cardinality metrics from kube-state-metrics which aren't used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao June 15, 2021 13:14
@arajkumar
Copy link
Contributor Author

/cc @simonpasquier

@arajkumar arajkumar closed this Jun 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@arajkumar: This pull request references Bugzilla bug 1955483. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Bug 1955483: [4.6] Drop high-cardinality metrics from kube-state-metrics which aren't used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison Awaiting requested review from bison

@paulfantom paulfantom Awaiting requested review from paulfantom

@juzhao juzhao Awaiting requested review from juzhao

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees
No one assigned
Labels
bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arajkumar @simonpasquier