Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHODS Usage and Availability metrics #1232

Merged
merged 1 commit into from Jun 23, 2021
Merged

Add RHODS Usage and Availability metrics #1232

merged 1 commit into from Jun 23, 2021

Conversation

anishasthana
Copy link
Member

Relevant request and approval can be found at https://docs.google.com/document/d/1P9TbVXA6MnocUAFjQy0Cfs0dd_JZqvnM1Ao44Ken8t8/edit#

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@openshift-ci openshift-ci bot requested review from bison and dgrisonnet June 17, 2021 16:02
@anishasthana
Copy link
Member Author

/retest

1 similar comment
@anishasthana
Copy link
Member Author

/retest

@simonpasquier
Copy link
Contributor

out of curiosity in which project do the rules/metrics live?

@anishasthana
Copy link
Member Author

We're working on further consolidating these repos long term, but the rules themselves are defined at https://github.com/red-hat-data-services/odh-deployer/blob/main/monitoring/prometheus/prometheus.yaml#L420-L430.
The service monitor for federation is defined at https://github.com/red-hat-data-services/odh-manifests/blob/master/monitoring/base/rhods-service-monitor.yaml.

@anishasthana
Copy link
Member Author

/retest

1 similar comment
@anishasthana
Copy link
Member Author

/retest

@anishasthana
Copy link
Member Author

/retest
Tests seem flaky. Different ones have been failing.

@anishasthana
Copy link
Member Author

/retest

2 similar comments
@anishasthana
Copy link
Member Author

/retest

@anishasthana
Copy link
Member Author

/retest

@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 21, 2021
@anishasthana
Copy link
Member Author

/retest

2 similar comments
@anishasthana
Copy link
Member Author

/retest

@anishasthana
Copy link
Member Author

/retest

@anishasthana
Copy link
Member Author

/retest

@simonpasquier what can we do here? Should I just keep retesting until ci passes?

@anishasthana
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@anishasthana: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-single-node c634cc5 link /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit da01a98 into openshift:master Jun 23, 2021
@anishasthana anishasthana deleted the add_rhods_metrics branch June 23, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants