jsonnet/control-plane.libsonnet: Remove etcd rules

[lilic]

As per request we are moving the rules to CEO -> openshift/cluster-etcd-operator#613.

@openshift/openshift-team-monitoring please take a look.
cc @hexfusion

[lilic]

make: *** [assets/control-plane/etcd-prometheus-rule.yaml] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-06-21T12:25:02Z"}

🤷‍♀️ didn't get a chance to look into this yet, if someone has a hint?

[simonpasquier]

Hmm it seems to fail on assets/control-plane/etcd-prometheus-rule.yaml which are exactly the rules you're removing, right?

[lilic]

Is it maybe checking

cluster-monitoring-operator/pkg/manifests/manifests.go

Line 231 in 7168290

ControlPlaneEtcdPrometheusRule = "control-plane/etcd-prometheus-rule.yaml"

, and need to remove this as well?

[simonpasquier]

@lilic you've spotted it :)

[simonpasquier]

cluster-monitoring-operator/Makefile

Line 17 in 8ec92e1

ASSETS=$(shell grep -oh '[^"]*/.*\.yaml' pkg/manifests/manifests.go | sed 's/^/assets\//')

[lilic]

Ah nice, that explains it!

[lilic]

I guess we need to delete the ControlPlaneEtcdPrometheusRule first if it exists.

[lilic]

@simonpasquier please take another look, thanks!

[lilic]

No clue what this is, I think its legacy?

[simonpasquier]

Haha, not completely until the etcd service monitor moves to CEO too :)
But yes it's fine to remove the tests.

cluster-monitoring-operator/pkg/operator/operator.go

Lines 641 to 647 in 8ec92e1

	if caFound && len(caContent) > 0 &&
	certFound && len(certContent) > 0 &&
	keyFound && len(keyContent) > 0 {
	trueBool := true
	c.ClusterMonitoringConfiguration.EtcdConfig.Enabled = &trueBool
	}

[simonpasquier]

/lgtm
/hold
Holding to let @lilic merge this whenever you want/need.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lilic]

Watchdog alert had missing intervals during the run, which may be a sign of a Prometheus outage in violation of the prometheus query SLO of 100% uptime during upgrade

/retest

[lilic]

/retest

unrelated failures

[lilic]

alert KubePodCrashLooping fired for 2209 seconds with labels: {container="thanos-query", endpoint="https-main", job="kube-state-metrics", namespace="openshift-monitoring", pod="thanos-querier-d4d687cc-g4fzq", service="kube-state-metrics", severity="warning"}

I don't think its related to my change, but this keeps firing. 🤔

[lilic]

/retest

[openshift-ci]

@lilic: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-single-node	9719e18	link	/test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[lilic]

/retest

[lilic]

/hold cancel