Bug 1978829: alert: ClusterMonitoringOperatorReconciliationErrors: reduce range du… #1268
Conversation
…ration and add for clause
openshift-ci
bot
added
bugzilla/severity-medium
|
@philipgough: This pull request references Bugzilla bug 1978829, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@philipgough: This pull request references Bugzilla bug 1978829, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
|
/lgtm |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
| @@ -360,8 +360,9 @@ function(params) { | |||
| // Should be used to suppress alerts during control plane upgrades or disruption. | |||
| }, | |||
| { | |||
| expr: 'max(max_over_time(cluster_monitoring_operator_last_reconciliation_successful[1h])) == 0', | |||
| expr: 'max_over_time(cluster_monitoring_operator_last_reconciliation_successful[5m]) == 0', | |||
There was a problem hiding this comment.
We have a resync period of 15m - https://github.com/openshift/cluster-monitoring-operator/blob/master/pkg/operator/operator.go#L111. This means the alert may be flapping as we are taking shorter range than resync interval.
There was a problem hiding this comment.
NVM, I was mistaken how this works
/lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, paulfantom, PhilipGough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@philipgough: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@philipgough: All pull requests linked via external trackers have merged: Bugzilla bug 1978829 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ration and add for clause