client: Always set OperatorUpgradeable reason to AsExpected #1275
Conversation
We always set the OperatorUpgradeable status condition on the ClusterOperator resource to True, but we sometimes change the message to indiciate errors. This has proved confusing for users because the errors are also indicated in the other status condition messages and the Upgradeable condition has not actually changed values. This always sets the Upgradeable condition to true with an "AsExpcted" reason.
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bison, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@bison: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
We always set the OperatorUpgradeable status condition on the
ClusterOperator resource to True, but we sometimes change the message
to indiciate errors. This has proved confusing for users because the
errors are also indicated in the other status condition messages and
the Upgradeable condition has not actually changed values. This
always sets the Upgradeable condition to true with an "AsExpcted"
reason.