Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/manifests: Add EnforcedTargetLimit for user-workload monitoring #1278

Merged
merged 1 commit into from Jul 12, 2021
Merged

pkg/manifests: Add EnforcedTargetLimit for user-workload monitoring #1278

merged 1 commit into from Jul 12, 2021

Conversation

bison
Copy link
Contributor

@bison bison commented Jul 12, 2021

This adds support for configuring the EnforcedTargetLimit for the
user-workload Prometheus instance. This lets admins set an overall
limit on the number of targets scraped.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2021
@bison
pkg/manifests: Add EnforcedTargetLimit for user-workload monitoring
b81d78b 
This adds support for configuring the EnforcedTargetLimit for the
user-workload Prometheus instance.  This lets admins set an overall
limit on the number of targets scraped.
@fpetkovski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2021
simonpasquier
simonpasquier reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison, fpetkovski, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bison,fpetkovski,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2021

@bison: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-single-node b81d78b link /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a054912 into openshift:master Jul 12, 2021
@bison bison deleted the uwm-target-limit branch July 12, 2021 14:44
@simonpasquier simonpasquier mentioned this pull request Sep 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@fpetkovski fpetkovski Awaiting requested review from fpetkovski

@prashbnair prashbnair Awaiting requested review from prashbnair

Assignees

@fpetkovski fpetkovski

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bison @fpetkovski @openshift-bot @simonpasquier @openshift-merge-robot