Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1987246: node exporter calls /proc/cpuinfo multiple times causing the node to freeze #1304

Merged
merged 2 commits into from Aug 18, 2021
Merged

[release-4.6] Bug 1987246: node exporter calls /proc/cpuinfo multiple times causing the node to freeze #1304

merged 2 commits into from Aug 18, 2021

Conversation

arajkumar
Copy link
Contributor

Cherry-pick #1272

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

bison and others added 2 commits July 29, 2021 15:58
@bison @arajkumar
jsonnet: Disable cpufreq collector in node_exporter
12caf11 
The node_exporter cpufreq collector seems to be causing high load on
some machines with lots of cores.  This disables it temporarily as a
workaround until the issue can be addressed upstream.  We don't seem
to rely on these metrics anywhere.

See: https://bugzilla.redhat.com/show_bug.cgi?id=1972076

Signed-off-by: Arunprasad Rajkumar <arajkuma@redhat.com>
@arajkumar
assets: regenerate
88cf610 
Signed-off-by: Arunprasad Rajkumar <arajkuma@redhat.com>
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

@arajkumar: This pull request references Bugzilla bug 1987246, which is invalid:

  • expected dependent Bugzilla bug 1981871 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1987246: node exporter calls /proc/cpuinfo multiple times causing the node to freeze

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 29, 2021
@arajkumar
Copy link
Contributor Author

/assign @simonpasquier

@dgrisonnet
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

@dgrisonnet: This pull request references Bugzilla bug 1987246, which is invalid:

  • expected dependent Bugzilla bug 1981871 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

@dgrisonnet: This pull request references Bugzilla bug 1987246, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1986591 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1986591 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 3, 2021
@openshift-ci openshift-ci bot requested a review from juzhao August 3, 2021 07:32
@dgrisonnet
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2021
@juzhao
Copy link

juzhao commented Aug 10, 2021

tested with the PR, no issue
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 10, 2021
@simonpasquier
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arajkumar, dgrisonnet, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021
@deads2k
Copy link
Contributor

deads2k commented Aug 18, 2021

/cherry-pick-approved
?

@deads2k
Copy link
Contributor

deads2k commented Aug 18, 2021

/cherrypick approved

@openshift-cherrypick-robot
Copy link

@deads2k: once the present PR merges, I will cherry-pick it on top of approved in a new PR and assign it to you.

In response to this:

/cherrypick approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Aug 18, 2021

sigh

@deads2k deads2k added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6209301 into openshift:release-4.6 Aug 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

@arajkumar: All pull requests linked via external trackers have merged:

Bugzilla bug 1987246 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1987246: node exporter calls /proc/cpuinfo multiple times causing the node to freeze

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@deads2k: cannot checkout approved: error checking out approved: exit status 1. output: error: pathspec 'approved' did not match any file(s) known to git

In response to this:

/cherrypick approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Aug 18, 2021

patch manager: urgent BZ, already qe-approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@simonpasquier simonpasquier

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@arajkumar @dgrisonnet @juzhao @simonpasquier @deads2k @openshift-cherrypick-robot @openshift-merge-robot @bison