Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-1688: Expose remote write #1308

Merged
merged 3 commits into from Aug 27, 2021
Merged

MON-1688: Expose remote write #1308

merged 3 commits into from Aug 27, 2021

Conversation

jan--f
Copy link
Contributor

@jan--f jan--f commented Jul 30, 2021 •
edited

This is a WIP PR as prometheus-operator/prometheus-operator#4180 is still being reviewed

This exposes remote_writeto users. CMO gets its own remote_write struct in order to hide unsafe fields (like BearerToken and TLSConfig) and to potentially add fields later so simpler specification for this feature.

  • I added CHANGELOG entry for this change.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2021
@openshift-ci openshift-ci bot requested review from raptorsun and sthaha July 30, 2021 13:23
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2021
@jan--f jan--f force-pushed the expose-remote-write branch 3 times, most recently from e01fe28 to e72b0df Compare August 16, 2021 11:50
simonpasquier
simonpasquier reviewed Aug 16, 2021
View reviewed changes
go.mod Outdated
@@ -29,3 +29,5 @@ require (
)

replace k8s.io/client-go => k8s.io/client-go v0.21.2

replace github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.48.1 => github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.49.1-0.20210803083158-78e0ea966b65
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stick with v0.49.0 and leave aside Authorization and OAuth2 support for now (it can be added in 4.10 once we upgrade to a version of the Prometheus operator supporting them).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, good point ty.

@jan--f jan--f force-pushed the expose-remote-write branch 3 times, most recently from 4e36ab7 to f9cb9ee Compare August 17, 2021 07:22
@jan--f jan--f changed the title [WIP] Expose remote write Expose remote write Aug 17, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2021
@jan--f jan--f changed the title Expose remote write MON-1069: Expose remote write Aug 17, 2021
@jan--f jan--f changed the title MON-1069: Expose remote write MON-1688: Expose remote write Aug 17, 2021
@jan--f jan--f force-pushed the expose-remote-write branch 2 times, most recently from 6ba8dca to 5dd1a80 Compare August 18, 2021 08:56
@simonpasquier
Copy link
Contributor

/lgtm

@simonpasquier
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021
@simonpasquier
Copy link
Contributor

/test e2e-agnostic-upgrade

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@juzhao
Copy link

juzhao commented Aug 27, 2021

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 27, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@simonpasquier
Copy link
Contributor

/test e2e-agnostic

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jan--f
Copy link
Contributor Author

jan--f commented Aug 27, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2021
@jan--f
Copy link
Contributor Author

jan--f commented Aug 27, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2021 •
edited

@jan--f: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/versions f1422bf link /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 280b572 into openshift:master Aug 27, 2021
@jan--f jan--f mentioned this pull request Sep 3, 2021
Merged
@simonpasquier simonpasquier mentioned this pull request Sep 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@raptorsun raptorsun Awaiting requested review from raptorsun

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jan--f @simonpasquier @openshift-bot @sferich888 @rkratky @juzhao @openshift-merge-robot