New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1990258: cleaning up Makefile #1311
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, prashbnair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/bugzilla refresh |
@paulfantom: This pull request references Bugzilla bug 1990258, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@paulfantom: This pull request references Bugzilla bug 1990258, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@paulfantom: All pull requests linked via external trackers have merged: Bugzilla bug 1990258 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Noticed during openshift/release#20887 development. Without this, on clean repository
make versions
fails as it cannot installgojsontoyaml
dependency due to incorrectly named make targets.Additionally, I added a note of deprecating
generate-in-docker
as it is no longer needed after we switched to use jsonnet and not python script.$(GOBINDATA_BIN)
wasn't used for a long time (I think around 4.6 we did a switch).