New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2039119: assets: let CVO manage the CMO Service resource #1537
Bug 2039119: assets: let CVO manage the CMO Service resource #1537
Conversation
Problem: In 23c29ca the CMO service resource was changed to be managed by CVO (by creating it in the asset/ subdir). See the commit/PR for motivation. The service however was not removed from the assets that CMO should create itself, leading to CVO and CMO competing over this resource Solution: Remove the resource from the CMO-managed resources. Issues: https://bugzilla.redhat.com/show_bug.cgi?id=2039119 https://bugzilla.redhat.com/show_bug.cgi?id=2016352 Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@jan--f: This pull request references Bugzilla bug 2039119, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@jan--f: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jan--f: All pull requests linked via external trackers have merged: Bugzilla bug 2039119 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem: In
23c29ca the
CMO service resource was changed to be managed by CVO (by creating it in
the asset/ subdir). See the commit/PR for motivation. The service
however was not removed from the assets that CMO should create itself,
leading to CVO and CMO competing over this resource
Solution: Remove the resource from the CMO-managed resources.
Issues: https://bugzilla.redhat.com/show_bug.cgi?id=2039119
https://bugzilla.redhat.com/show_bug.cgi?id=2016352
Signed-off-by: Jan Fajerski jfajersk@redhat.com