New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename kube_pv to odf_system_pvs #1756
Conversation
Hi @weirdwiz. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as for your other PR: you need to keep the old metric around.
PTAL @simonpasquier |
This lgtm, but will let @simonpasquier give final approval. |
/label docs-approved |
@weirdwiz please run |
/skip |
/retest |
/lgtm |
This commit renames the metric, in order to better indicate to the user that the metric just represents the number of PVs created by ODF instead of the total number of persistent volumes in a cluster. Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
@simonpasquier can you tag this again? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, simonpasquier, weirdwiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@weirdwiz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This commit renames the metric, in order to better indicate to the user
that the metric just represents the number of PVs created by ODF instead
of the total number of persistent volumes in a cluster.}|
https://issues.redhat.com/browse/RHSTOR-3472