pkg/manifests: allow to configure enforced limits on PrometheusK8sConfig

[fgouteroux]

Hello

These limits should be available also on ClusterMonitoringConfiguration and not only for UserWorkloadConfiguration:

• enforcedLabelLimit
• enforcedLabelNameLengthLimit
• enforcedLabelValueLengthLimit
• enforcedSampleLimit
• enforcedTargetLimit

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

[openshift-ci]

Hi @fgouteroux. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[simonpasquier]

👋 thanks for the PR! Can you open a JIRA ticket here and provide more details about your use case?
Feature requests like this need to go through our product management first.

[fgouteroux]

wave thanks for the PR! Can you open a JIRA ticket here and provide more details about your use case? Feature requests like this need to go through our product management first.

sure, will do it. Opened issue here. I don't know if I use the correct project for the issue.

[fgouteroux]

Hello, any chance to get this PR merged ? @simonpasquier

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fgouteroux
Once this PR has been reviewed and has the lgtm label, please assign joaobravecoding for approval by writing /assign @joaobravecoding in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fgouteroux]

Any update ?

[openshift-ci]

@raptorsun: The label(s) /label ok-to-test cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[raptorsun]

/ok-to-test

[fgouteroux]

/retest

[openshift-ci]

@fgouteroux: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	8da27db	link	false	/test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fgouteroux]

@raptorsun One test is failed due to Cluster operator csi-snapshot-controller. Could we move forward without this test as it is not required ?

[raptorsun]

@raptorsun One test is failed due to Cluster operator csi-snapshot-controller. Could we move forward without this test as it is not required ?

Thanks for your PR :)
No worries about the non-required test e2e-aws-single-node.
As @simonpasquier mentioned, we need check with product manager on this new feature PR.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.