Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-1994: Patch Alert KubePodNotReady to exclude installer pods. #1790

Closed
wants to merge 1 commit into from
Closed

OCPBUGS-1994: Patch Alert KubePodNotReady to exclude installer pods. #1790

wants to merge 1 commit into from

Conversation

raptorsun
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

The alert KubePodNotReady will exclude installer pods.
This PR resolves the problem of pinning the alert while receiving other updates from upstream components. (ref #1788)

https://issues.redhat.com/browse/MON-2821

@openshift-ci openshift-ci bot requested review from jan--f and slashpai October 4, 2022 19:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2022
@raptorsun raptorsun mentioned this pull request Oct 4, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

@raptorsun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 9096762 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

simonpasquier
simonpasquier reviewed Oct 5, 2022
View reviewed changes
jsonnet/utils/sanitize-rules.libsonnet
Comment on lines +202 to +204
labels: {
severity: 'warning',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

jsonnet/utils/sanitize-rules.libsonnet
@@ -183,6 +183,27 @@ local patchedRules = [
},
'for': '30m',
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment explaining why we override the alert and a link to the pod installer bug (not sure if we have it already)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth linking to https://issues.redhat.com/browse/TRT-589 since we want the override to go away eventually.

simonpasquier
simonpasquier reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also bump the kube-prometheus jsonnet version? meaning building the change on top of #1770

@simonpasquier
Copy link
Contributor

/retitle OCPBUGS-1994: Patch Alert KubePodNotReady to exclude installer pods.

@simonpasquier
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@openshift-ci openshift-ci bot changed the title [MON-2821] Patch Alert KubePodNotReady to exclude installer pods. OCPBUGS-1994: Patch Alert KubePodNotReady to exclude installer pods. Oct 5, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 5, 2022
@openshift-ci-robot
Copy link
Contributor

@raptorsun: This pull request references Jira Issue OCPBUGS-1994, which is invalid:

  • expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

The alert KubePodNotReady will exclude installer pods.
This PR resolves the problem of pinning the alert while receiving other updates from upstream components. (ref #1788)

https://issues.redhat.com/browse/MON-2821

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raptorsun
Copy link
Contributor Author

could you also bump the kube-prometheus jsonnet version? meaning building the change on top of #1770

Yup, the new PR #1792 has been created to include jsonnet dependencies update and the patch on the alert KubePodNotReady.

This PR is going to
/close

@openshift-ci openshift-ci bot closed this Oct 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2022

@raptorsun: Closed this PR.

In response to this:

could you also bump the kube-prometheus jsonnet version? meaning building the change on top of #1770

Yup, the new PR #1792 has been created to include jsonnet dependencies update and the patch on the alert KubePodNotReady.

This PR is going to
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@raptorsun: This pull request references Jira Issue OCPBUGS-1994. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

The alert KubePodNotReady will exclude installer pods.
This PR resolves the problem of pinning the alert while receiving other updates from upstream components. (ref #1788)

https://issues.redhat.com/browse/MON-2821

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raptorsun raptorsun deleted the feature/mon-2821 branch October 7, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@jan--f jan--f Awaiting requested review from jan--f

@slashpai slashpai Awaiting requested review from slashpai

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raptorsun @simonpasquier @openshift-ci-robot