Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-4030: test: increase timeout when checking remote write metrics #1821

Merged
merged 1 commit into from Nov 25, 2022
Merged

[release-4.11] OCPBUGS-4030: test: increase timeout when checking remote write metrics #1821

merged 1 commit into from Nov 25, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1817

/assign simonpasquier

@simonpasquier
test: increase timeout when checking remote write metrics
0b153a5 
The
TestPrometheusRemoteWrite/assert_remote_write_cluster_id_relabel_config_works
test often fails in the CI. Looking at a successful run [1], the test
takes more than 2 minutes to run while the sub-test checking the
presence of the cluster_id label only retries for 2 minutes. Extending
the timeout to 4 minutes makes sense to me because there are lots of
conditions that need to be met for the test to succeed:
* Prometheus instance configured as remote write receiver is running.
* CMO propagates remote-write configuration to k8s Prometheus.
* Prometheus operator generates the new Prometheus configuration.
* config-reloader picks up the new configuration and reloads Prometheus.
* Samples with the new label appear in the remote write receiver.

[1] https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_prometheus/145/pull-ci-openshift-prometheus-master-e2e-agnostic-cmo/1592089698631684096/artifacts/e2e-agnostic-cmo/test/build-log.txt
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 23, 2022
Merged
2 tasks
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-4024 has been cloned as Jira Issue OCPBUGS-4030. Retitling PR to link against new bug.
/retitle [release-4.11] OCPBUGS-4030: test: increase timeout when checking remote write metrics

In response to this:

This is an automated cherry-pick of #1817

/assign simonpasquier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] OCPBUGS-4024: test: increase timeout when checking remote write metrics [release-4.11] OCPBUGS-4030: test: increase timeout when checking remote write metrics Nov 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-4030: test: increase timeout when checking remote write metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 23, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-4030, which is invalid:

  • expected dependent Jira Issue OCPBUGS-4024 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-4024 to target a version in 4.12.0, but it targets "4.13.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1817

/assign simonpasquier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoaoBraveCoding
Copy link
Contributor

/skip
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@jan--f
Copy link
Contributor

jan--f commented Nov 23, 2022

/label backport-risk-assessed
Thanks!

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 23, 2022
@JoaoBraveCoding
Copy link
Contributor

/retest-required

1 similar comment
@JoaoBraveCoding
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 0b153a5 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@juzhao
Copy link

juzhao commented Nov 25, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 25, 2022
@juzhao
Copy link

juzhao commented Nov 25, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 25, 2022
@JoaoBraveCoding
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 25, 2022
@openshift-ci-robot
Copy link
Contributor

@JoaoBraveCoding: This pull request references Jira Issue OCPBUGS-4030, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-4029 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-4029 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao November 25, 2022 10:37
@openshift-merge-robot openshift-merge-robot merged commit a397875 into openshift:release-4.11 Nov 25, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4030 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1817

/assign simonpasquier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

@sthaha sthaha Awaiting requested review from sthaha

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@simonpasquier simonpasquier

@JoaoBraveCoding JoaoBraveCoding

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @JoaoBraveCoding @jan--f @juzhao @simonpasquier @openshift-merge-robot