MON-3113: add nodeExporter.collectors.mountstats settings. #1936

raptorsun · 2023-04-05T10:08:46Z

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

openshift-ci-robot · 2023-04-05T10:08:49Z

@raptorsun: This pull request references MON-3113 which is a valid jira issue.

In response to this:

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

raptorsun · 2023-04-11T09:47:23Z

/retest

raptorsun · 2023-04-14T19:01:19Z

/retest-required

raptorsun · 2023-04-17T08:13:37Z

/retest-required

Tai-RedHat · 2023-05-16T23:59:32Z

test PR with cluster-bot, but I can not find the following metrics after enabling mountstats

1. node_mountstats_nfs_read_bytes_total
2. node_mountstats_nfs_write_bytes_total
3. node_mountstats_nfs_operations_requests_total

Is it necessary to attach NFS pv to see the metrics?

simonpasquier · 2023-05-31T12:45:32Z

pkg/manifests/types.go

+//	`node_mountstats_nfs_operations_requests_total`.
+//
+// Please be aware that these metric can have a high cardinality.
+// If you enable this collector, watch the prometheus-k8s deployment closely for excessive memory usage.


Suggested change

// If you enable this collector, watch the prometheus-k8s deployment closely for excessive memory usage.

// If you enable this collector, monitor closely any increase of the memory usage for the prometheus-k8s pods.

raptorsun · 2023-06-01T07:27:24Z

test PR with cluster-bot, but I can not find the following metrics after enabling mountstats
1. node_mountstats_nfs_read_bytes_total
2. node_mountstats_nfs_write_bytes_total
3. node_mountstats_nfs_operations_requests_total
Is it necessary to attach NFS pv to see the metrics?

Yes, it is necessary to have an NFS volume mounted on the host to see these metrics.

simonpasquier

/lgtm

Tai-RedHat · 2023-06-02T02:37:19Z

test PR with cluster-bot, but I can not find the following metrics after enabling mountstats
1. node_mountstats_nfs_read_bytes_total
2. node_mountstats_nfs_write_bytes_total
3. node_mountstats_nfs_operations_requests_total
Is it necessary to attach NFS pv to see the metrics?
Yes, it is necessary to have an NFS volume mounted on the host to see these metrics.

Use cluster-bot test again, able to see above metrics.
/label qe-approved

raptorsun · 2023-06-02T06:55:43Z

/retest-required

raptorsun · 2023-06-02T06:58:38Z

Hello @bburt-rh @Senthamilarasu-STA, could you please have a look and stamp it with labels "docs-approved" and "px-approved"? Thanks :)

simonpasquier · 2023-06-02T09:21:45Z

/skip

simonpasquier · 2023-06-05T12:39:51Z

/retest-required

Documentation/openshiftdocs/modules/nodeexportercollectormountstatsconfig.adoc

Documentation/openshiftdocs/modules/nodeexportercollectorconfig.adoc

pkg/manifests/types.go

raptorsun · 2023-06-07T19:36:04Z

Thank you @bburt-rh :D I have updated the documentation accordingly. Could you please review it again?

bburt-rh · 2023-06-07T19:58:15Z

/label docs-approved

openshift-ci · 2023-06-07T22:03:21Z

@raptorsun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	`fc6435a`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/versions	`fc6435a`	link	false	`/test versions`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

danielmellado · 2023-06-08T09:05:48Z

/lgtm

openshift-ci · 2023-06-08T09:06:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, raptorsun, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [raptorsun,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 5, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2023

openshift-ci bot requested review from slashpai and sthaha April 5, 2023 10:09

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023

raptorsun force-pushed the feature/MON-3113 branch 2 times, most recently from e6d3db4 to 320919f Compare April 6, 2023 10:14

raptorsun changed the title ~~[WIP] MON-3113: add nodeExporter.collectors.mountstats settings.~~ MON-3113: add nodeExporter.collectors.mountstats settings. Apr 11, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2023

raptorsun force-pushed the feature/MON-3113 branch 2 times, most recently from 8c87a93 to 71df1c8 Compare April 24, 2023 17:17

simonpasquier reviewed May 31, 2023

View reviewed changes

raptorsun force-pushed the feature/MON-3113 branch from 71df1c8 to 7eb885b Compare June 1, 2023 08:58

simonpasquier reviewed Jun 1, 2023

View reviewed changes

openshift-ci bot assigned simonpasquier Jun 1, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 2, 2023