Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.13] OCPBUGS-14251: Add new web console usage metrics #1976

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented May 30, 2023

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Fixes: OCPBUGS-12903

This is a manual backport of #1910 and the final PR to add this metrics to 4.13 (not 4.13.0)

Cherry-pick worked fine without any conflict. I just added another CHANGELOG line for 4.13.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 30, 2023
@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-14251, which is invalid:

  • expected dependent Jira Issue OCPBUGS-12903 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual backport of #1970

Cherry-pick worked fine without any conflict. I just added another CHANGELOG line for 4.13.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-14251, which is invalid:

  • expected dependent Jira Issue OCPBUGS-12903 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Fixes: OCPBUGS-12903

This is a manual backport of #1970 and the final PR to add this metrics to 4.13 (not 4.13.0)

Cherry-pick worked fine without any conflict. I just added another CHANGELOG line for 4.13.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

@jerolimov
Copy link
Member Author

/assign @simonpasquier

@openshift-ci openshift-ci bot requested a review from sthaha May 30, 2023 08:17
@jerolimov jerolimov changed the title OCPBUGS-14251: Add new web console usage metrics [release-4.13] OCPBUGS-14251: Add new web console usage metrics May 30, 2023
@@ -3,6 +3,7 @@
## 4.14

- [#1937](https://github.com/openshift/cluster-monitoring-operator/pull/1937) Disables btrfs collector
- [#1910](https://github.com/openshift/cluster-monitoring-operator/pull/1910) Add new web console usage metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not strictly needed as it's only for internal use.

@simonpasquier
Copy link
Contributor

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 30, 2023
@jerolimov
Copy link
Member Author

/retest

@jerolimov
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 3, 2023
@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-14251, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12903 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-12903 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanketpathak
Copy link

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

@sanketpathak: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor

/assign @juzhao

@juzhao
Copy link

juzhao commented Jun 8, 2023

FYI: I see the 4.14 PR is merged, checked with 4.14.0-0.nightly-2023-06-05-112833, the 7 added metrics are not in telemeter server allow list, https://github.com/rhobs/configuration/blob/main/configuration/telemeter/metrics.json
so we can not find the metrics from telemeter server, should also submit PR to add metrics to telemeter server allow list

@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-14251, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12903 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-12903 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Fixes: OCPBUGS-12903

This is a manual backport of #1910 and the final PR to add this metrics to 4.13 (not 4.13.0)

Cherry-pick worked fine without any conflict. I just added another CHANGELOG line for 4.13.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@jerolimov
Copy link
Member Author

Thanks @juzhao for the review.

I opened #1997 to fix these issues also on the master and cherry-picked the commit into this PR as well.

Can you please take a fresh look. Thanks :)

@jerolimov jerolimov requested a review from juzhao June 12, 2023 08:54
@jerolimov
Copy link
Member Author

FYI: I see the 4.14 PR is merged, checked with 4.14.0-0.nightly-2023-06-05-112833, the 7 added metrics are not in telemeter server allow list, https://github.com/rhobs/configuration/blob/main/configuration/telemeter/metrics.json so we can not find the metrics from telemeter server, should also submit PR to add metrics to telemeter server allow list

Thanks @juzhao for that information. I wasn't aware of that before and created rhobs/configuration#510 for that. Did you know who can take a look?

cc @simonpasquier

@juzhao
Copy link

juzhao commented Jun 12, 2023

/lgtm
for rhobs/configuration#510, maybe @philipgough can help on review the PR

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, juzhao, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juzhao
Copy link

juzhao commented Jun 12, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 12, 2023
@jerolimov
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 3777e7b into openshift:release-4.13 Jun 12, 2023
13 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

@jerolimov: Jira Issue OCPBUGS-14251: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14251 has been moved to the MODIFIED state.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Fixes: OCPBUGS-12903

This is a manual backport of #1910 and the final PR to add this metrics to 4.13 (not 4.13.0)

Cherry-pick worked fine without any conflict. I just added another CHANGELOG line for 4.13.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2023-06-12-183948

@jerolimov jerolimov deleted the add-console-metrics-4.13 branch November 20, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants