Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-14380: Fix golangcilint whitespace violations #1977

Merged
merged 1 commit into from Jun 1, 2023
Merged

OCPBUGS-14380: Fix golangcilint whitespace violations #1977

merged 1 commit into from Jun 1, 2023

Conversation

danielmellado
Copy link
Contributor

This PR fixes whitespace violations as per the new makefile target for
golangci-lint.

Signed-off-by: Daniel Mellado dmellado@redhat.com

@danielmellado
Fix golangcilint whitespace violations
d456195 
This PR fixes whitespace violations as per the new makefile target for
golangci-lint.

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
simonpasquier
simonpasquier reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@jan--f
Copy link
Contributor

jan--f commented May 30, 2023

/lgtm
/label docs-approved
/label px-approved
/label qe-approved
Adding labels for an internal refactoring.

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels May 30, 2023
@machine424
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, jan--f, machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danielmellado danielmellado changed the title Fix golangcilint whitespace violations OCPBUGS-14380: Fix golangcilint whitespace violations May 31, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 31, 2023
@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Jira Issue OCPBUGS-14380, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR fixes whitespace violations as per the new makefile target for
golangci-lint.

Signed-off-by: Daniel Mellado dmellado@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danielmellado
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Jira Issue OCPBUGS-14380, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danielmellado
Copy link
Contributor Author

/retest-required

@openshift-ci openshift-ci bot requested a review from juzhao May 31, 2023 17:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023 •
edited

@danielmellado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions d456195 link false /test versions
ci/prow/e2e-aws-ovn-single-node d456195 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD eac5ca9 and 2 for PR HEAD d456195 in total

@openshift-merge-robot openshift-merge-robot merged commit 549ed3b into openshift:master Jun 1, 2023
13 of 15 checks passed
@openshift-ci-robot
Copy link
Contributor

@danielmellado: Jira Issue OCPBUGS-14380: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14380 has been moved to the MODIFIED state.

In response to this:

This PR fixes whitespace violations as per the new makefile target for
golangci-lint.

Signed-off-by: Daniel Mellado dmellado@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@jan--f jan--f

@simonpasquier simonpasquier

@machine424 machine424

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@danielmellado @jan--f @machine424 @openshift-ci-robot @simonpasquier @openshift-merge-robot