Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-14606: Remove remaining staticcheck violations #1989

Merged
merged 1 commit into from Jun 6, 2023
Merged

OCPBUGS-14606: Remove remaining staticcheck violations #1989

merged 1 commit into from Jun 6, 2023

Conversation

danielmellado
Copy link
Contributor

This PR removes remaining static check violations in the CMO that
showed up after fixing all the other issues.

Signed-off-by: Daniel Mellado dmellado@redhat.com

@danielmellado
Remove remaining staticcheck violations
9beb4ce 
This commit removes remaining static check violations in the CMO that
showed up after fixing all the other issues.

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 6, 2023
@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Jira Issue OCPBUGS-14606, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR removes remaining static check violations in the CMO that
showed up after fixing all the other issues.

Signed-off-by: Daniel Mellado dmellado@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 6, 2023
@danielmellado
Copy link
Contributor Author

/retest-required

1 similar comment
@danielmellado
Copy link
Contributor Author

/retest-required

simonpasquier
simonpasquier reviewed Jun 6, 2023
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@danielmellado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 9beb4ce link false /test e2e-aws-ovn-single-node
ci/prow/versions 9beb4ce link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6240e93 into openshift:master Jun 6, 2023
13 of 15 checks passed
@openshift-ci-robot
Copy link
Contributor

@danielmellado: Jira Issue OCPBUGS-14606: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14606 has been moved to the MODIFIED state.

In response to this:

This PR removes remaining static check violations in the CMO that
showed up after fixing all the other issues.

Signed-off-by: Daniel Mellado dmellado@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@juzhao juzhao Awaiting requested review from juzhao

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

@slashpai slashpai Awaiting requested review from slashpai

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danielmellado @openshift-ci-robot @simonpasquier @openshift-merge-robot