Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14123: make TestBodySizeLimit less flaky #1991

Merged
merged 2 commits into from Jun 19, 2023

Conversation

raptorsun
Copy link
Contributor

TestBodySizeLimit checks Prometheus config file instead of the metric "prometheus_target_scrapes_exceeded_body_size_limit_total".

The package "github.com/prometheus/prometheus/discovery/kubernetes" is added to vendor/ to parse the field kubernetes_sd_configs in the config file.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 7, 2023
@openshift-ci-robot
Copy link
Contributor

@raptorsun: This pull request references Jira Issue OCPBUGS-14123, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

TestBodySizeLimit checks Prometheus config file instead of the metric "prometheus_target_scrapes_exceeded_body_size_limit_total".

The package "github.com/prometheus/prometheus/discovery/kubernetes" is added to vendor/ to parse the field kubernetes_sd_configs in the config file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 7, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@juzhao
Copy link

juzhao commented Jun 16, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 16, 2023
@juzhao
Copy link

juzhao commented Jun 19, 2023

/test versions

@simonpasquier
Copy link
Contributor

/skip

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [raptorsun,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

@raptorsun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 5d55ff5 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit eaa38ec into openshift:master Jun 19, 2023
16 checks passed
@openshift-ci-robot
Copy link
Contributor

@raptorsun: Jira Issue OCPBUGS-14123: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14123 has been moved to the MODIFIED state.

In response to this:

TestBodySizeLimit checks Prometheus config file instead of the metric "prometheus_target_scrapes_exceeded_body_size_limit_total".

The package "github.com/prometheus/prometheus/discovery/kubernetes" is added to vendor/ to parse the field kubernetes_sd_configs in the config file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants