OCPBUGS-13153: Merge TestNodeExporterGenericOptions and TestNodeExporterGoMaxProcs tests #1998
Conversation
machine424
commented
Jun 12, 2023
machine424
commented
- I added CHANGELOG entry for this change.
- No user facing changes, so no entry in CHANGELOG was needed.
On nodes with multiple CPU cores, this should help avoid lock contentions without having any side effects, see the ticket for more details. node-exporter versions that have "--runtime.gomaxprocs" can still override this: the flag has precedence over this automatic setting. Make the entrypoint set the env var before runnning the process. Get the CPU count from /proc/cpuinfo without taking CPU affinity (via cpuset) into account as the container's CPU requests is not an integer, thus no affinity is applied. Signed-off-by: Ayoub Mrini <amrini@redhat.com>
…terGoMaxProcs tests Do it in a seperate PR to ease backporitng openshift#1996 as the maxprocs config wasn't present in < 4.14 Signed-off-by: Ayoub Mrini <amrini@redhat.com>
machine424
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@machine424: This pull request references Jira Issue OCPBUGS-13153, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: machine424 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@machine424: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close The new test was removed |
|
@machine424: This pull request references Jira Issue OCPBUGS-13153. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@machine424: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
