New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-14922: skip console-plugin installation if console CO is absent #2011
OCPBUGS-14922: skip console-plugin installation if console CO is absent #2011
Conversation
@sthaha: This pull request references Jira Issue OCPBUGS-14922, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
66211b3
to
58de492
Compare
/jira refresh |
@jan--f: This pull request references Jira Issue OCPBUGS-14922, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
681364c
to
934c4df
Compare
8f03f88
to
2910eb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The handleEvent() function needs to react on changes to the clusterversion object.
cluster-monitoring-operator/pkg/operator/operator.go
Lines 568 to 596 in 8d67591
if _, ok := obj.(*configv1.Infrastructure); ok { | |
klog.Infof("Triggering update due to an infrastructure update") | |
o.enqueue(cmoConfigMap) | |
return | |
} | |
if _, ok := obj.(*configv1.APIServer); ok { | |
klog.Infof("Triggering update due to an apiserver config update") | |
o.enqueue(cmoConfigMap) | |
return | |
} | |
if _, ok := obj.(*v1.PersistentVolumeClaim); ok { | |
klog.Info("Triggering update due to a PVC update") | |
o.enqueue(cmoConfigMap) | |
return | |
} | |
if _, ok := obj.(*configv1.Console); ok { | |
klog.Info("Triggering update due to a console update") | |
o.enqueue(cmoConfigMap) | |
return | |
} | |
if _, ok := obj.(*configv1.ClusterOperator); ok { | |
klog.Info("Triggering update due to a cluster operator update") | |
o.enqueue(cmoConfigMap) | |
return | |
} |
I'd also replace the existing if blocks by type switches (e.g. https://go.dev/tour/methods/16).
e67e7a1
to
f7f1f87
Compare
/retest-required |
… is disabled This PR fixes the failure to upgrade from OpenShift version 4.13 to 4.14 in environments (such as telco) where `console` capability is disabled. The upgrade fails when CMO executes the console-plugin task which fails due to missing ConsolePlugin CRD. The fix checks if `console` capability is enabled in ClusterVersion - version and bails out (with a log message) if it is disabled. Signed-off-by: Sunil Thaha <sthaha@redhat.com>
f7f1f87
to
3aac627
Compare
/retest-required |
1 similar comment
/retest-required |
@sthaha: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, sthaha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dde6f7e
into
openshift:master
@sthaha: Jira Issue OCPBUGS-14922: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-14922 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR fixes the failure to upgrade from OpenShift version 4.13 to 4.14 in environments (such as telco) where
console
ClusterOperator is disabled. The upgrade fails happens when CMO executes the console-plugin task which fails due to missing ConsolePlugin.The fix checks for the presence of
console
ClusterOperator and bails out (with a log message) if it is absent.