Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-3180: Expose and propagate TopologySpreadConstraints for telemeter-client #2017

Merged
merged 2 commits into from Jul 7, 2023
Merged

MON-3180: Expose and propagate TopologySpreadConstraints for telemeter-client #2017

merged 2 commits into from Jul 7, 2023

Conversation

marioferh
Copy link
Contributor

Give users a TopologySpreadConstraints field in the TelemeterClientConfig field and propagate this to the pod that is created.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 27, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 27, 2023 •
edited by openshift-ci bot

@marioferh: This pull request references MON-3180 which is a valid jira issue.

In response to this:

Give users a TopologySpreadConstraints field in the TelemeterClientConfig field and propagate this to the pod that is created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jan--f and raptorsun June 27, 2023 07:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@danielmellado
Copy link
Contributor

/retest-required

@marioferh marioferh force-pushed the topology_spread_constrains_telemeter_client branch from 37f181e to 97bafe0 Compare June 27, 2023 09:26
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023
@marioferh
Add topology wip
549ec69 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh
Add Docs, make generate
1aecbe2 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh marioferh force-pushed the topology_spread_constrains_telemeter_client branch from d72d17a to 1aecbe2 Compare July 6, 2023 12:01
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2023
jan--f
jan--f approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, marioferh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 60f4899 and 2 for PR HEAD 1aecbe2 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 26622a6 and 1 for PR HEAD 1aecbe2 in total

@openshift-merge-robot openshift-merge-robot merged commit 9ebcbe4 into openshift:master Jul 7, 2023
13 of 16 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

@marioferh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 1aecbe2 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f jan--f approved these changes

@raptorsun raptorsun Awaiting requested review from raptorsun

Assignees

@jan--f jan--f

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marioferh @openshift-ci-robot @danielmellado @jan--f @openshift-merge-robot