Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-3177: Expose and propagate TopologySpreadConstraints for kube state metrics #2026

Merged
merged 1 commit into from Jul 18, 2023
Merged

MON-3177: Expose and propagate TopologySpreadConstraints for kube state metrics #2026

merged 1 commit into from Jul 18, 2023

Conversation

marioferh
Copy link
Contributor

Give users a TopologySpreadConstraints field in the kubeStateMetrcisConfig field and propagate this to the pod that is created.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 28, 2023 •
edited by openshift-ci bot

@marioferh: This pull request references MON-3177 which is a valid jira issue.

In response to this:

Give users a TopologySpreadConstraints field in the kubeStateMetrcisConfig field and propagate this to the pod that is created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@marioferh
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023
@marioferh marioferh changed the title MON-3177: Expose and propagate TopologySpreadConstraints for prometheus-adapter MON-3177: Expose and propagate TopologySpreadConstraints for kube state metrics Jul 5, 2023
@marioferh
Add topology spread constrains
0a7fc58 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh marioferh force-pushed the topology_spread_constrains_kube_state_metrics branch from d731adf to 0a7fc58 Compare July 6, 2023 11:58
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2023
@raptorsun
Copy link
Contributor

/retest-required

2 similar comments
@marioferh
Copy link
Contributor Author

/retest-required

@marioferh
Copy link
Contributor Author

/retest-required

@jan--f
Copy link
Contributor

jan--f commented Jul 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, marioferh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marioferh
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c929284 and 2 for PR HEAD 0a7fc58 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cd076c6 and 1 for PR HEAD 0a7fc58 in total

@marioferh
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@marioferh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8bdfcf5 into openshift:master Jul 18, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmellado danielmellado Awaiting requested review from danielmellado

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@jan--f jan--f

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marioferh @openshift-ci-robot @raptorsun @jan--f @openshift-merge-robot