Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-3181: Expose and propagate TopologySpreadConstraints for thanos-querier #2035

Merged
merged 1 commit into from Jul 6, 2023
Merged

MON-3181: Expose and propagate TopologySpreadConstraints for thanos-querier #2035

merged 1 commit into from Jul 6, 2023

Conversation

marioferh
Copy link
Contributor

Give users a TopologySpreadConstraints field in the ThanosQuerier field and propagate this to the pod that is created.

@marioferh
Add topology spread constrains
991bf69 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 5, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 5, 2023 •
edited by openshift-ci bot

@marioferh: This pull request references MON-3181 which is a valid jira issue.

In response to this:

Give users a TopologySpreadConstraints field in the ThanosQuerier field and propagate this to the pod that is created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@raptorsun
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioferh, raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [marioferh,raptorsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 01ec473 into openshift:master Jul 6, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

Assignees

@raptorsun raptorsun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marioferh @openshift-ci-robot @raptorsun @openshift-merge-robot