MON-3182: Expose and propagate TopologySpreadConstraints for UWM alertmanager #2037
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@marioferh: This pull request references MON-3182 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
marioferh
changed the title
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
marioferh
force-pushed
the
topology_spread_constrains_UWM_alertmanager
branch
from
1945c89
to
b621e7f
Compare
| c := NewDefaultConfig() | ||
| c.UserWorkloadConfiguration.Alertmanager.Secrets = []string{"test-secret", "slack-api-token"} | ||
| uwc, err := NewUserConfigFromString(`alertmanager: |
There was a problem hiding this comment.
I think this is the correct way to check UWM.
| matchLabels: | ||
| foo: bar | ||
| secrets: | ||
| - test-secret |
There was a problem hiding this comment.
Also added here previous test and change the test name in order to include all UWM test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, marioferh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@marioferh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Give users a TopologySpreadConstraints field in the AlertmanagerUserWorkloadConfig field and propagate this to the pod that is created.