MON-3215: drop techpreview gate for collection profiles #2046

rexagod · 2023-07-18T19:55:45Z

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

openshift-ci-robot · 2023-07-18T19:55:48Z

@rexagod: This pull request references MON-3215 which is a valid jira issue.

In response to this:

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rexagod · 2023-07-18T20:00:25Z

/jira refresh

openshift-ci-robot · 2023-07-18T20:00:27Z

@rexagod: This pull request references MON-3215 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

slashpai · 2023-07-27T07:24:55Z

pkg/manifests/config.go

@@ -52,7 +52,6 @@ const (
 type Config struct {
 	Images      *Images `json:"-"`
 	RemoteWrite bool    `json:"-"`
-	TechPreview bool    `json:"-"`


We have metrics-server PR also using same config so I think we can still keep this config and drop the check only for collection profile?

slashpai · 2023-07-27T07:25:27Z

pkg/manifests/config.go

@@ -190,7 +189,7 @@ func (cps CollectionProfiles) String() string {
 	return sb.String()
 }

-func NewConfig(content io.Reader, tp bool) (*Config, error) {
+func NewConfig(content io.Reader) (*Config, error) {


same comment above regarding metrics-server

slashpai · 2023-07-27T07:25:42Z

pkg/manifests/config.go

 // some features are only meant for TechPreview.
-func NewConfigFromString(content string, tp bool) (*Config, error) {


same comment above regarding metrics-server

simonpasquier · 2023-08-01T15:43:10Z

I agree with @slashpai to keep the TP bool because it will be reusable in the future.

openshift-bot · 2023-10-31T01:00:35Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

slashpai · 2023-11-07T15:31:23Z

/test e2e-aws-ovn-techpreview

openshift-bot · 2023-12-08T00:30:25Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2024-01-07T08:00:17Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2024-01-07T08:00:28Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rexagod · 2024-02-28T18:57:02Z

/reopen

openshift-ci · 2024-02-28T18:59:51Z

@rexagod: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-02-28T19:02:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rexagod]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-02-28T19:02:10Z

@rexagod: This pull request references MON-3215 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rexagod · 2024-02-29T07:01:54Z

/retest

rexagod · 2024-03-05T08:10:55Z

/retest

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

openshift-ci · 2024-03-11T23:53:17Z

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/versions	`6d6895e`	link	false	`/test versions`
ci/prow/e2e-aws-ovn-techpreview	`6d6895e`	link	true	`/test e2e-aws-ovn-techpreview`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rexagod · 2024-03-28T07:49:04Z

Replace TP with FG.

slashpai · 2024-03-28T12:22:42Z

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Note: This CHANGELOG is only for the monitoring team to track all monitoring related changes. Please see OpenShift release notes for official changes.

+## 4.16
+
+- [#2046](https://github.com/openshift/cluster-monitoring-operator/pull/2046) Drop TechPreview gate for CollectionProfiles.


IIUC we added this as a TechPreviewNoUpgrade FeatureGate so for this PR there is no user change log?

ACK, the TP was replaced by the newly introduced ways of using feature-gates in #2153. At the moment there is no changelog entry for this, but we might want to point out to users that this is available in TP behind a certain FG if they want to use it. WDYT?

rexagod · 2024-03-28T20:39:49Z

/close
#2046 (comment) was addressed in #2153. Reopen when (and if) we want to drop the feature-gate entirely (after this is enabled by default).

openshift-ci · 2024-03-28T20:40:30Z

@rexagod: Closed this PR.

In response to this:

/close
#2046 (comment) was addressed in #2153. Reopen when (and if) we want to drop the feature-gate entirely (after this is enabled by default).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 18, 2023

rexagod force-pushed the MON-3215 branch from cdececc to a867d53 Compare July 18, 2023 19:57

openshift-ci bot requested review from jan--f and JoaoBraveCoding July 18, 2023 20:01

rexagod force-pushed the MON-3215 branch 3 times, most recently from 154cfe6 to c99feb9 Compare July 19, 2023 07:08

slashpai reviewed Jul 27, 2023

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2023

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2023

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 8, 2023

openshift-ci bot closed this Jan 7, 2024

openshift-ci bot reopened this Feb 28, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024

rexagod force-pushed the MON-3215 branch from c99feb9 to c48298c Compare February 28, 2024 19:58

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024

rexagod force-pushed the MON-3215 branch 2 times, most recently from 7b7b30e to 21591fd Compare February 28, 2024 20:53

rexagod mentioned this pull request Mar 7, 2024

MON-3486: add feature gate for Collection Profiles openshift/api#1670

Merged

1 task

chore: drop tech-preview for collection-profiles

6d6895e

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

rexagod force-pushed the MON-3215 branch from 21591fd to 6d6895e Compare March 11, 2024 21:03

slashpai reviewed Mar 28, 2024

View reviewed changes

openshift-ci bot closed this Mar 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MON-3215: drop techpreview gate for collection profiles #2046

MON-3215: drop techpreview gate for collection profiles #2046

rexagod commented Jul 18, 2023

openshift-ci-robot commented Jul 18, 2023 •

edited by openshift-ci bot

rexagod commented Jul 18, 2023

openshift-ci-robot commented Jul 18, 2023 •

edited by openshift-ci bot

slashpai Jul 27, 2023

slashpai Jul 27, 2023

slashpai Jul 27, 2023

simonpasquier commented Aug 1, 2023

openshift-bot commented Oct 31, 2023

slashpai commented Nov 7, 2023

openshift-bot commented Dec 8, 2023

openshift-bot commented Jan 7, 2024

openshift-ci bot commented Jan 7, 2024

rexagod commented Feb 28, 2024

openshift-ci bot commented Feb 28, 2024

openshift-ci bot commented Feb 28, 2024

openshift-ci-robot commented Feb 28, 2024 •

edited by openshift-ci bot

rexagod commented Feb 29, 2024

rexagod commented Mar 5, 2024

openshift-ci bot commented Mar 11, 2024

rexagod commented Mar 28, 2024 •

edited

slashpai Mar 28, 2024

rexagod Mar 28, 2024

rexagod commented Mar 28, 2024

openshift-ci bot commented Mar 28, 2024

		// some features are only meant for TechPreview.
		func NewConfigFromString(content string, tp bool) (*Config, error) {

MON-3215: drop techpreview gate for collection profiles #2046

MON-3215: drop techpreview gate for collection profiles #2046

Conversation

rexagod commented Jul 18, 2023

openshift-ci-robot commented Jul 18, 2023 • edited by openshift-ci bot

rexagod commented Jul 18, 2023

openshift-ci-robot commented Jul 18, 2023 • edited by openshift-ci bot

slashpai Jul 27, 2023

Choose a reason for hiding this comment

slashpai Jul 27, 2023

Choose a reason for hiding this comment

slashpai Jul 27, 2023

Choose a reason for hiding this comment

simonpasquier commented Aug 1, 2023

openshift-bot commented Oct 31, 2023

slashpai commented Nov 7, 2023

openshift-bot commented Dec 8, 2023

openshift-bot commented Jan 7, 2024

openshift-ci bot commented Jan 7, 2024

rexagod commented Feb 28, 2024

openshift-ci bot commented Feb 28, 2024

openshift-ci bot commented Feb 28, 2024

openshift-ci-robot commented Feb 28, 2024 • edited by openshift-ci bot

rexagod commented Feb 29, 2024

rexagod commented Mar 5, 2024

openshift-ci bot commented Mar 11, 2024

rexagod commented Mar 28, 2024 • edited

slashpai Mar 28, 2024

Choose a reason for hiding this comment

rexagod Mar 28, 2024

Choose a reason for hiding this comment

rexagod commented Mar 28, 2024

openshift-ci bot commented Mar 28, 2024

openshift-ci-robot commented Jul 18, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Jul 18, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 28, 2024 •

edited by openshift-ci bot

rexagod commented Mar 28, 2024 •

edited