OCPBUGS-1062: update webhook configuration only if required

[simonpasquier]

This change uses the ApplyValidatingWebhookConfigurationImproved method from the github.com/openshift/library-go module instead of the previous custom implementation.

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

[openshift-ci-robot]

@simonpasquier: This pull request references Jira Issue OCPBUGS-1062, which is invalid:

• expected the bug to target the "4.14.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change uses the ApplyValidatingWebhookConfigurationImproved method from the github.com/openshift/library-go module instead of the previous custom implementation.

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[simonpasquier]

/jira refresh

[openshift-ci-robot]

@simonpasquier: This pull request references Jira Issue OCPBUGS-1062, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[simonpasquier]

/hold

[simonpasquier]

/test e2e-aws-ovn

[simonpasquier]

The audit logs from the latest e2e-aws-ovn run show an improvement in terms of update frequency

$ kubectl-dev_tool -f registry-build01-ci-openshift-org-ci-op-lm26kgc5-stable-sha256-512cd85c0443d448916b2282d49163771fb319b1abb6bd18e75b2b42ca3064af/audit_logs/ audit --resource=validatingwebhookconfigurations.* --user=system:serviceaccount:openshift-monitoring:cluster-monitoring-operator --verb update
had 83757 line read failures
10:18:31 [UPDATE][     2.987ms] [200] /apis/admissionregistration.k8s.io/v1/validatingwebhookconfigurations/prometheusrules.openshift.io     [system:serviceaccount:openshift-monitoring:cluster-monitoring-operator]
10:18:31 [UPDATE][     2.987ms] [200] /apis/admissionregistration.k8s.io/v1/validatingwebhookconfigurations/prometheusrules.openshift.io     [system:serviceaccount:openshift-monitoring:cluster-monitoring-operator]
10:18:31 [UPDATE][     2.942ms] [200] /apis/admissionregistration.k8s.io/v1/validatingwebhookconfigurations/alertmanagerconfigs.openshift.io [system:serviceaccount:openshift-monitoring:cluster-monitoring-operator]
10:18:31 [UPDATE][     2.942ms] [200] /apis/admissionregistration.k8s.io/v1/validatingwebhookconfigurations/alertmanagerconfigs.openshift.io [system:serviceaccount:openshift-monitoring:cluster-monitoring-operator]

[simonpasquier]

/retest

[simonpasquier]

/hold cancel

[juzhao]

@simonpasquier tested with cluster-bot cluster with PR
launch openshift/cluster-monitoring-operator#2065
watched prometheus-operator-admission-webhook pod logs for a few minutes, still see 1-2 error logs remote error: tls: bad certificate, see http://pastebin.test.redhat.com/1107240, much more less than that in 4.12 bug OCPBUGS-1062

[simonpasquier]

@juzhao yes I'm quite sure that it won't fix all remote error: tls: ... log messages but it should definitely help.
Chatted with @rexagod and we want to apply the same optimization to all the create/update operations performed by CMO.

[juzhao]

/label qe-approved

[jan--f]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@simonpasquier: Jira Issue OCPBUGS-1062: All pull requests linked via external trackers have merged:

• openshift/cluster-monitoring-operator#2065

Jira Issue OCPBUGS-1062 has been moved to the MODIFIED state.

In response to this:

This change uses the ApplyValidatingWebhookConfigurationImproved method from the github.com/openshift/library-go module instead of the previous custom implementation.

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.