Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-19356: Topology spread constraints admission webhook #2073

Conversation

marioferh
Copy link
Contributor

Add Topology spread constrains admission webhook

Add tests

@marioferh
Copy link
Contributor Author

marioferh commented Aug 14, 2023

/hold
wait for #2067

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
@marioferh marioferh changed the title Topology spread constrains admission webhook MON-3320: Topology spread constrains admission webhook Aug 14, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 14, 2023

@marioferh: This pull request references MON-3320 which is a valid jira issue.

In response to this:

Add Topology spread constrains admission webhook

Add tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@juzhao
Copy link

juzhao commented Aug 16, 2023

/retest-required

@jan--f
Copy link
Contributor

jan--f commented Aug 16, 2023

/hold

#2067 was changed, so this PR needs updating.

@marioferh marioferh force-pushed the topology_spread_constrains_admission_webhook branch 2 times, most recently from b8635c8 to 7770ea5 Compare August 29, 2023 08:44
@marioferh
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

@marioferh
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
pkg/manifests/manifests.go Outdated Show resolved Hide resolved
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh marioferh force-pushed the topology_spread_constrains_admission_webhook branch from 7770ea5 to d36d2ca Compare September 11, 2023 10:10
@marioferh
Copy link
Contributor Author

/retest-required

@jan--f
Copy link
Contributor

jan--f commented Sep 12, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, marioferh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juzhao
Copy link

juzhao commented Sep 13, 2023

tested with PR, topologySpreadConstraints is added for prometheus-operator-admission-webhook, and no regression issues
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 13, 2023
@jan--f
Copy link
Contributor

jan--f commented Sep 18, 2023

/retitle OCPBUGS-19356: Topology spread constraints admission webhook

@openshift-ci openshift-ci bot changed the title MON-3320: Topology spread constrains admission webhook OCPBUGS-19356: Topology spread constraints admission webhook Sep 18, 2023
@openshift-ci-robot
Copy link
Contributor

@marioferh: This pull request references Jira Issue OCPBUGS-19356, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add Topology spread constrains admission webhook

Add tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 18, 2023
@openshift-ci openshift-ci bot requested a review from juzhao September 18, 2023 18:54
@jan--f
Copy link
Contributor

jan--f commented Sep 18, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot

@jan--f: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 024aebd and 2 for PR HEAD d36d2ca in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

@marioferh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2f9f0af into openshift:master Sep 18, 2023
16 checks passed
@openshift-ci-robot
Copy link
Contributor

@marioferh: Jira Issue OCPBUGS-19356: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19356 has been moved to the MODIFIED state.

In response to this:

Add Topology spread constrains admission webhook

Add tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jan--f: new pull request created: #2088

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants