Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add machine424 and rexagod to OWNERS #2083

Merged
merged 1 commit into from Oct 5, 2023
Merged

add machine424 and rexagod to OWNERS #2083

merged 1 commit into from Oct 5, 2023

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Sep 13, 2023

Also moved JoaoBraveCoding to emeritus.

cc @jan--f @machine424

machine424
machine424 reviewed Sep 13, 2023
View reviewed changes
OWNERS
@@ -6,9 +6,10 @@ reviewers:
- raptorsun
- slashpai
- sthaha
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can excuse Sunil as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so Sunil has moved to Keplar permanently? Not quite sure if we should.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looping in @jan--f here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, let's remove sunil for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 really the folks regularly participating in our sprints are meant to be in this list.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

@rexagod: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 17a21f2 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danielmellado
Copy link
Contributor

/lgtm

danielmellado
danielmellado approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@danielmellado danielmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@openshift-ci openshift-ci bot merged commit 1767491 into openshift:master Oct 5, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f jan--f left review comments

@machine424 machine424 machine424 left review comments

@danielmellado danielmellado danielmellado approved these changes

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@danielmellado danielmellado

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rexagod @danielmellado @jan--f @machine424