OCPVE-711: feat: add olm capability annotation #2105
Conversation
OLM is an optional operator, we exclude OLM resources with this annotation if the monitoring operator ever becomes a capability, using a <monitoring_label>+OperatorLifecycleManager will work for both Signed-off-by: ehila <ehila@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request references OCPVE-711 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/hold
|
Hey @danielmellado, Sure thing! Openshift has the capabilities feature documented in this enhancement, This allows us to annotate manifests for specific operators and make them optional during install. The reason that this PR exists is because the OperatorLifecycleManager is going to be optional in 4.15, the deployment of OperatorGroup fails during install, so we add this annotation and CVO will know how to handle it correctly. If all goods from your end, feel free to slap a lgtm/approve, we're getting final validation and I'll go ahead and unhold it once the change is in CVO. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@eggfoobar: This pull request references OCPVE-711 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@eggfoobar thanks for addressing my comment there and adding the clarification, it does lgtm but I'd like for @jan--f or @simonpasquier to take a look at this too, thanks! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, eggfoobar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hello @eggfoobar Are you sure this is sufficient to avoid deploying that resource once a cluster disable OLM? I'm afraid this would implicitly re-enable OLM back: I think this is documented in here https://github.com/openshift/enhancements/blob/cb81452fddf86c1099acd87610b88369cd6192db/enhancements/installer/component-selection.md#updates but maybe it's something worth mentioning in https://github.com/openshift/enhancements/tree/master/dev-guide/cluster-version-operator as well (I'm not sure, maybe I'm getting it wrong, but a more explicit doc will help in all cases) |
OLM is an optional operator, we exclude OLM resources with this annotation if the monitoring operator ever becomes a capability, using a <monitoring_label>+OperatorLifecycleManager will work for both
Openshift has the capabilities feature documented in this enhancement, This allows us to annotate manifests for specific operators and make them optional during install. The reason that this PR exists is because the OperatorLifecycleManager is going to be optional in 4.15, the deployment of OperatorGroup fails during install, so we add this annotation and CVO will know how to handle it correctly.
/hold
Wait for CVO to be merged in first openshift/cluster-version-operator#971