MON-3379: Replace the oauth-proxy before thanos-querier with kube-rbac-proxy #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
jira/valid-reference
|
@raptorsun: This pull request references MON-3379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
raptorsun
force-pushed
the
MON-3379
branch
2 times, most recently
from
bd85d0f
to
edbe951
Compare
|
@raptorsun: This pull request references MON-3379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
raptorsun
force-pushed
the
MON-3379
branch
3 times, most recently
from
f0dc752
to
6b96382
Compare
raptorsun
changed the title
raptorsun
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
raptorsun
force-pushed
the
MON-3379
branch
4 times, most recently
from
ec9abfe
to
d1072dc
Compare
|
@raptorsun: This pull request references MON-3379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@raptorsun: This pull request references MON-3379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@raptorsun: This pull request references MON-3379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
raptorsun
force-pushed
the
MON-3379
branch
2 times, most recently
from
5d85669
to
943a085
Compare
|
/retest |
|
@raptorsun: This pull request references MON-3379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@raptorsun: This pull request references MON-3379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The failing |
raptorsun
commented
Nov 21, 2023
| - --tls-private-key-file=/etc/tls/private/tls.key | ||
| - --tls-cipher-suites=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 | ||
| - --allow-paths=/api/v1/query,/api/v1/query_range,/api/v1/format_query,/api/v1/series,/api/v1/labels,/api/v1/label/*/values,/api/v1/query_exemplars,/api/v1/targets,/api/v1/rules,/api/v1/alerts,/api/v1/targets/metadata,/api/v1/metadata,/api/v1/alertmanagers,/api/v1/status/* | ||
| - -v=10 |
There was a problem hiding this comment.
remove this before merging.
|
@raptorsun is this PR ready for test? |
raptorsun
force-pushed
the
MON-3379
branch
3 times, most recently
from
48b9230
to
be7c141
Compare
|
Using dedicated service account for each access test in TestMonitoringApiRoles works well :D |
|
/test e2e-agnostic-operator |
test/e2e/thanos_querier_test.go
Outdated
| t.Cleanup(func() { | ||
| err := cf() | ||
| if err != nil { | ||
| t.Fatal(err) |
There was a problem hiding this comment.
I would rather log because the last run failed on this line
There was a problem hiding this comment.
Yup, will add a log here.
Last run failed due to a connection reset issue. It may takes too long to delete the namespace.
|
/test e2e-agnostic-operator |
I have submitted a PR to update the koku-metrics-operator, hoping it can help avoid interrupting the operator's function with our change in CMO. |
|
project-koku/koku-metrics-operator#240 has been merged. koku operator will not be interrupted after the proxy replacement. |
|
Pending Simons last comments, this looks good to me. |
openshift-ci
bot
added
docs-approved
|
@raptorsun: This pull request references MON-3379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thank you very much for reviewing @simonpasquier @jan--f |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raptorsun, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is ready to test now :) |
openshift-merge-bot
bot
merged commit 8b657e3
into
openshift:master
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to review and merge 🥳
✅ Service accounts able to access Thanos Querier web port:
⛔ Service accounts that used to be able to access Thanos Querier web port but no longer accessible now: