Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22742: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to 0.44.0 #2138

Merged
merged 1 commit into from Nov 6, 2023

Conversation

marioferh
Copy link
Contributor

No description provided.

Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 2, 2023
@openshift-ci-robot
Copy link
Contributor

@marioferh: This pull request references Jira Issue OCPBUGS-22515, which is invalid:

  • expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.14.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@marioferh marioferh changed the title OCPBUGS-22515: fix: update opentelemetry to v1.19.0/v0.44.0 OCPBUGS-22515: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to 0.44.0 Nov 2, 2023
@marioferh marioferh changed the title OCPBUGS-22515: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to 0.44.0 OCPBUGS-22742: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to 0.44.0 Nov 2, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 2, 2023
@openshift-ci-robot
Copy link
Contributor

@marioferh: This pull request references Jira Issue OCPBUGS-22742, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 2, 2023
@openshift-ci openshift-ci bot requested a review from juzhao November 2, 2023 10:59
@marioferh
Copy link
Contributor Author

/retest-required

@marioferh
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

@jan--f
Copy link
Contributor

jan--f commented Nov 2, 2023

The impacted dependecies are all listed as indirect. Iiuc this means that a direct dependency uses the vulnerable otel library.
Going by

cluster-monitoring-operator (git)-[master] % go mod why go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
# go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
github.com/openshift/cluster-monitoring-operator/pkg/metrics
k8s.io/apiserver/pkg/server
k8s.io/apiserver/pkg/endpoints/filters
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp

We get this via k8s.io/apiserver. They have a fix in kubernetes/apiserver@7bd3403 but I'm not sure if that was tagged yet.

@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioferh, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [marioferh,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

@marioferh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5a4cfa9 into openshift:master Nov 6, 2023
16 checks passed
@openshift-ci-robot
Copy link
Contributor

@marioferh: Jira Issue OCPBUGS-22742: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22742 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-11-07-012445

@marioferh
Copy link
Contributor Author

/cherrypick release-4.14

@openshift-cherrypick-robot

@marioferh: new pull request created: #2239

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants