Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable real e2e tests again #214

Merged
merged 3 commits into from
Jan 28, 2019

Conversation

mxinden
Copy link
Contributor

@mxinden mxinden commented Jan 21, 2019

We want to bring back the end to end tests that @mxinden started and continue working on them.
This PR reverts some of the changes made in #185.

Supersedes #206

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2019
@mxinden
Copy link
Contributor Author

mxinden commented Jan 21, 2019

/test e2e-aws-operator

1 similar comment
@mxinden
Copy link
Contributor Author

mxinden commented Jan 23, 2019

/test e2e-aws-operator

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2019
@mxinden
Copy link
Contributor Author

mxinden commented Jan 24, 2019

/test e2e-aws-operator

1 similar comment
@mxinden
Copy link
Contributor Author

mxinden commented Jan 24, 2019

/test e2e-aws-operator

@mxinden mxinden changed the title [WIP] test: Enable real e2e tests again test: Enable real e2e tests again Jan 24, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2019
Copy link
Contributor

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, couldn't even find a nitpick 🙂 👍

@mxinden
Copy link
Contributor Author

mxinden commented Jan 24, 2019

/test e2e-aws
/test images

@mxinden
Copy link
Contributor Author

mxinden commented Jan 24, 2019

/retest

@mxinden
Copy link
Contributor Author

mxinden commented Jan 24, 2019 via email

@brancz
Copy link
Contributor

brancz commented Jan 28, 2019

nice job!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, metalmatze, mxinden

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brancz
Copy link
Contributor

brancz commented Jan 28, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit d9aeeb1 into openshift:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants