Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] MON-3462: remove temporary fix for TRT-589 #2142

Closed
wants to merge 1 commit into from
Closed

[WIP] MON-3462: remove temporary fix for TRT-589 #2142

wants to merge 1 commit into from

Conversation

simonpasquier
Copy link
Contributor

@simonpasquier simonpasquier commented Nov 3, 2023 •
edited by openshift-ci bot

TRT-589 [1] required to patch the upstream KubePodNotReady alerting rule. Now that the original issue is fixed, we should be able to revert the patch.

[1] https://issues.redhat.com/browse/TRT-589

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@simonpasquier
MON-3462: remove temporary fix for TRT-589
4116237 
TRT-589 [1] required to patch the upstream KubePodNotReady alerting
rule. Now that the original issue is fixed, we should be able to revert
the patch.

[1] https://issues.redhat.com/browse/TRT-589

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2023 •
edited by openshift-ci bot

@simonpasquier: This pull request references MON-3462 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

TRT-589 [1] required to patch the upstream KubePodNotReady alerting rule. Now that the original issue is fixed, we should be able to revert the patch.

[1] https://issues.redhat.com/browse/TRT-589

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2023 •
edited by openshift-ci bot

@simonpasquier: This pull request references MON-3462 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

TRT-589 [1] required to patch the upstream KubePodNotReady alerting rule. Now that the original issue is fixed, we should be able to revert the patch.

[1] https://issues.redhat.com/browse/TRT-589

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor Author

/cc @neisw

@simonpasquier
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot requested a review from neisw November 3, 2023 08:49
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@machine424
Copy link
Contributor

machine424 commented Nov 6, 2023 •
edited

Some origin tests are still failing in ci/prow/e2e-aws-ovn maybe we should adapt them as well.
(didn't see it was held)

@danielmellado
Copy link
Contributor

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

@simonpasquier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 4116237 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn 4116237 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview 4116237 link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor Author

/wip

I'm not actively working on it for now.

@simonpasquier simonpasquier changed the title MON-3462: remove temporary fix for TRT-589 [WIP] MON-3462: remove temporary fix for TRT-589 Nov 27, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2023
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 27, 2024
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Apr 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 27, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neisw neisw Awaiting requested review from neisw

@danielmellado danielmellado Awaiting requested review from danielmellado

@machine424 machine424 Awaiting requested review from machine424

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@simonpasquier @openshift-ci-robot @machine424 @danielmellado @openshift-bot