Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3503: Synchronize versions of the downstream components #2150

Conversation

openshift-monitoring-bot[bot]
Copy link

Description

This pull request updates jsonnet/versions.yaml to match with the already in use downstream versions of the monitoring components.

Based on that file, it regenerates the assets to update some metadata (mainly the app.kubernetes.io/version annotation) attached to some of the resources and update other placeholders.

It is safe to merge this change (provided that the CI jobs pass).

If you wish to perform this manually, execute the following commands from cluster-monitoring-operator repository:

make versions
make generate

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2023
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

Hi @openshift-monitoring-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slashpai
Copy link
Member

slashpai commented Nov 8, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2023
@slashpai
Copy link
Member

slashpai commented Nov 8, 2023

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 8, 2023
@raptorsun
Copy link
Contributor

/label docs-approved
/label px-approved
/label jira/valid-reference

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Nov 9, 2023
Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

@raptorsun: The label(s) /label jira/valid-reference cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label docs-approved
/label px-approved
/label jira/valid-reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slashpai
Copy link
Member

slashpai commented Nov 9, 2023

/hold
Will wait for 0.69.1 release

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2023
@simonpasquier
Copy link
Contributor

/skip

@simonpasquier
Copy link
Contributor

Superseded by #2152.

@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-versions-generate branch from 71c7e4d to dde8678 Compare November 11, 2023 00:35
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2023
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-versions-generate branch from dde8678 to 8e36b3c Compare November 18, 2023 00:36
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@simonpasquier
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 20, 2023
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-versions-generate branch from 8e36b3c to c399b1a Compare November 21, 2023 00:37
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-versions-generate branch from c399b1a to 28765e2 Compare November 22, 2023 00:39
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

@openshift-monitoring-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023
@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-monitoring-bot[bot], simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [simonpasquier,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor

/label px-approved
/label qe-approved
no functional change

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Nov 22, 2023
@simonpasquier
Copy link
Contributor

simonpasquier commented Nov 22, 2023

/retitle MON-3503: Synchronize versions of the downstream components

@openshift-ci openshift-ci bot changed the title [bot] Synchronize versions of the downstream components MON-3503: Synchronize versions of the downstream components Nov 22, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 22, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 22, 2023

@openshift-monitoring-bot[bot]: This pull request references MON-3503 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Description

This pull request updates jsonnet/versions.yaml to match with the already in use downstream versions of the monitoring components.

Based on that file, it regenerates the assets to update some metadata (mainly the app.kubernetes.io/version annotation) attached to some of the resources and update other placeholders.

It is safe to merge this change (provided that the CI jobs pass).

If you wish to perform this manually, execute the following commands from cluster-monitoring-operator repository:

make versions
make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 4bdf151 into openshift:master Nov 22, 2023
17 checks passed
@simonpasquier simonpasquier deleted the automated-updates-master-versions-generate branch November 22, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants