Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3287: Remove openshift-etcd related RBAC as they will be manager by #2165

Merged
merged 1 commit into from Dec 1, 2023

Conversation

machine424
Copy link
Contributor

@machine424 machine424 commented Nov 23, 2023

cluster-etcd-operator now.

The resources may keep some of CMO related metadata, this is the trade-off to keep the same names and avoid unnecessary API calls in CMO.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

/hold

Will be managed in CEO here openshift/cluster-etcd-operator#1164

(tested installing a cluster with both PRs + upgrading with both PRs and didn't see any issues)

Will try to merge the CEO one first and this one just after (may get some transient clash that will not lead to downtime)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 23, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 23, 2023

@machine424: This pull request references MON-3287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

cluster-etcd-operator now.

The resources may keep some of CMO related metadata, this is the trade-off to keep the same names and avoid unnecessary API calls in CMO.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2023
machine424 added a commit to machine424/cluster-etcd-operator that referenced this pull request Nov 23, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@machine424
Copy link
Contributor Author

/retest

1 similar comment
@machine424
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 23, 2023

@machine424: This pull request references MON-3287 which is a valid jira issue.

In response to this:

cluster-etcd-operator now.

The resources may keep some of CMO related metadata, this is the trade-off to keep the same names and avoid unnecessary API calls in CMO.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

/hold

Will be managed in CEO here openshift/cluster-etcd-operator#1164

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machine424
Copy link
Contributor Author

/cc @simonpasquier

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 23, 2023

@machine424: This pull request references MON-3287 which is a valid jira issue.

In response to this:

cluster-etcd-operator now.

The resources may keep some of CMO related metadata, this is the trade-off to keep the same names and avoid unnecessary API calls in CMO.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

/hold

Will be managed in CEO here openshift/cluster-etcd-operator#1164

(tested installing a cluster with both PRs + upgrading with both PRs and didn't see any issues)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 23, 2023

@machine424: This pull request references MON-3287 which is a valid jira issue.

In response to this:

cluster-etcd-operator now.

The resources may keep some of CMO related metadata, this is the trade-off to keep the same names and avoid unnecessary API calls in CMO.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

/hold

Will be managed in CEO here openshift/cluster-etcd-operator#1164

(tested installing a cluster with both PRs + upgrading with both PRs and didn't see any issues)

Will try to merge the CEO one first and this one just after (may get some transient clash that will not lead to downtime)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machine424
Copy link
Contributor Author

/retest

cluster-etcd-operator now.

The resources may keep some of CMO related metadata, this is the trade-off to keep the
same names and avoid unnecessary API calls in CMO.
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [machine424,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@machine424
Copy link
Contributor Author

/retest

@machine424
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7dc0037 and 2 for PR HEAD 56b7fb3 in total

@machine424
Copy link
Contributor Author

alertmanager_user_workload_test.go:60: namespaces "user-workload-test" not found

Doesn't seem to be related.

/retest-required

Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 265bb99 into openshift:master Dec 1, 2023
17 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.15.0-202312011553.p0.g265bb99.assembly.stream for distgit cluster-monitoring-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants