New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MON-3287: Remove openshift-etcd related RBAC as they will be manager by #2165
Conversation
@machine424: This pull request references MON-3287 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
previously was managed by CMO see openshift/cluster-monitoring-operator#2165
5c2f293
to
9caffd0
Compare
/retest |
1 similar comment
/retest |
@machine424: This pull request references MON-3287 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @simonpasquier |
@machine424: This pull request references MON-3287 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@machine424: This pull request references MON-3287 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
cluster-etcd-operator now. The resources may keep some of CMO related metadata, this is the trade-off to keep the same names and avoid unnecessary API calls in CMO.
9caffd0
to
56b7fb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: machine424, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/unhold |
Doesn't seem to be related. /retest-required |
@machine424: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-monitoring-operator-container-v4.15.0-202312011553.p0.g265bb99.assembly.stream for distgit cluster-monitoring-operator. |
cluster-etcd-operator now.
The resources may keep some of CMO related metadata, this is the trade-off to keep the same names and avoid unnecessary API calls in CMO.
/hold
Will be managed in CEO here openshift/cluster-etcd-operator#1164
(tested installing a cluster with both PRs + upgrading with both PRs and didn't see any issues)
Will try to merge the CEO one first and this one just after (may get some transient clash that will not lead to downtime)