Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3548: [bot] Synchronize versions of the downstream components #2183

Conversation

openshift-monitoring-bot[bot]
Copy link

Description

This pull request updates jsonnet/versions.yaml to match with the already in use downstream versions of the monitoring components.

Based on that file, it regenerates the assets to update some metadata (mainly the app.kubernetes.io/version annotation) attached to some of the resources and update other placeholders.

It is safe to merge this change (provided that the CI jobs pass).

If you wish to perform this manually, execute the following commands from cluster-monitoring-operator repository:

make versions
make generate

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 6, 2023
Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

Hi @openshift-monitoring-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2023
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master-versions-generate branch from 1194ef6 to 5650563 Compare December 7, 2023 00:37
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

@openshift-monitoring-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

/lgtm

@simonpasquier
Copy link
Contributor

simonpasquier commented Dec 7, 2023

/retitle MON-3548: [bot] Synchronize versions of the downstream components

@openshift-ci openshift-ci bot changed the title [bot] Synchronize versions of the downstream components MON-3548: [bot] Synchronize versions of the downstream components Dec 7, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 7, 2023

@openshift-monitoring-bot[bot]: This pull request references MON-3548 which is a valid jira issue.

In response to this:

Description

This pull request updates jsonnet/versions.yaml to match with the already in use downstream versions of the monitoring components.

Based on that file, it regenerates the assets to update some metadata (mainly the app.kubernetes.io/version annotation) attached to some of the resources and update other placeholders.

It is safe to merge this change (provided that the CI jobs pass).

If you wish to perform this manually, execute the following commands from cluster-monitoring-operator repository:

make versions
make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 7, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-monitoring-bot[bot], simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c09d44f into openshift:master Dec 7, 2023
17 checks passed
@simonpasquier simonpasquier deleted the automated-updates-master-versions-generate branch December 7, 2023 08:03
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202312071150.p0.gc09d44f.assembly.stream for distgit cluster-monitoring-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants