OCPBUGS-24977: use 1.20 in go.mod #2199
Conversation
jan--f
commented
Dec 13, 2023
jan--f
commented
- I added CHANGELOG entry for this change.
- No user facing changes, so no entry in CHANGELOG was needed.
openshift-ci-robot
added
jira/valid-reference
|
@jan--f: This pull request references Jira Issue OCPBUGS-24977, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
…fork Since p-o v0.70.0 uses 1.21 and relies on 1.21 features we have some downstream commits to make it 1.20 compatible. We should revert this once we have 1.21 builder images. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
… with ART Reconciling with https://github.com/openshift/ocp-build-data/tree/d6144b91a62b62420bc595018cd9e59c32961a32/images/cluster-monitoring-operator.yml (cherry picked from commit 9bf8b12)
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@jan--f: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
| @@ -158,3 +158,5 @@ require ( | |||
| ) | |||
|
|
|||
| replace k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20230928195430-ce36a0c3bb67 | |||
|
|
|||
| replace github.com/prometheus-operator/prometheus-operator v0.70.0 => github.com/openshift/prometheus-operator v0.20.1-0.20231211152750-5bf04f3ca997 | |||
There was a problem hiding this comment.
I asume that the replace is just using whatever commit was just before this prometheus-operator/prometheus-operator@4e63f2f isn't it?
There was a problem hiding this comment.
I'm stating that as it might be worth a quick note in the PR/commit message, but that's a nit
There was a problem hiding this comment.
Nope this replaces upstream with the openshift clone. See the commit message for details.
There was a problem hiding this comment.
Ack then, I'd put a note on the PR but lgtm, thanks!
|
Just a minor nit, lgtm overall! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, jan--f, marioferh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/skip |
|
@jan--f: Jira Issue OCPBUGS-24977: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-24977 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202312141929.p0.g0e876ff.assembly.stream for distgit cluster-monitoring-operator. |
