Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-25800: Wait for 3 (instead of 2) consecutive failing reconcil… #2216

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[release-4.14] OCPBUGS-25800: Wait for 3 (instead of 2) consecutive failing reconcil… #2216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions pkg/operator/operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ func (pc *ProxyConfig) NoProxy() string {
const (
resyncPeriod = 15 * time.Minute
reconciliationPeriod = 5 * time.Minute
maxFailCount = 2

// see https://github.com/kubernetes/apiserver/blob/b571c70e6e823fd78910c3f5b9be895a756f4cbb/pkg/server/options/authentication.go#L239
apiAuthenticationConfigMap = "kube-system/extension-apiserver-authentication"
Expand Down Expand Up @@ -760,11 +759,16 @@ func (o *Operator) sync(ctx context.Context, key string) error {

func (o *Operator) reportFailed(ctx context.Context, report runReport) {
o.failedReconcileAttempts++
klog.Infof("ClusterOperator reportFailed (attempt %d).", o.failedReconcileAttempts)

if o.failedReconcileAttempts < maxFailCount {
klog.Infof("ClusterOperator reconciliation %d - skipping update", o.failedReconcileAttempts)
// Rate limit to avoid unnecessary status updates for temporary or transient errors that may resolve themselves within a few attempts.
// Ensure you have thoroughly considered all implications before adjusting the threshold.
// See: https://issues.redhat.com/browse/OCPBUGS-23745
maxAttempts := 3
if o.failedReconcileAttempts < maxAttempts {
klog.Infof("%d reconciliation(s) failed, %d more attempt(s) will be made before reporting failures.", o.failedReconcileAttempts, maxAttempts-o.failedReconcileAttempts)
return
} else {
klog.Infof("%d reconciliations failed in a row, the threshold of %d attempts has been reached, failures will be reported.", o.failedReconcileAttempts, maxAttempts)
}

if err := o.client.StatusReporter().ReportState(ctx, report); err != nil {
Expand Down