Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3654: use Go standard errors package instead of github.com/pkg/errors #2224

Merged
merged 2 commits into from Jan 12, 2024

Conversation

machine424
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2024

@machine424: This pull request references MON-3654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@machine424 machine424 marked this pull request as draft January 8, 2024 12:41
@machine424
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@@ -27,8 +29,16 @@ linters:
- whitespace
- gci

linter-settings:
Copy link
Contributor Author

@machine424 machine424 Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if we could enable strict unmarshalling in golangci

@openshift-ci openshift-ci bot requested review from jan--f and slashpai January 8, 2024 12:43
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@machine424
Copy link
Contributor Author

/retest

@machine424
Copy link
Contributor Author

/retest

@machine424 machine424 marked this pull request as ready for review January 8, 2024 19:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@openshift-ci openshift-ci bot requested a review from raptorsun January 8, 2024 19:21
@machine424
Copy link
Contributor Author

/retest

@jan--f
Copy link
Contributor

jan--f commented Jan 12, 2024

Nice improvement, thanks.
I'm a bit confused about the import reordering. If there is a string reason, sure let's do it. But then lets add a comment (or even better commit message) about the why.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2024
@machine424
Copy link
Contributor Author

I'm a bit confused about the import reordering. If there is a string reason, sure let's do it. But then lets add a comment (or even better commit message) about the why.

It's done in the second commit:

chore: add errorlint and depguard linters and fix gci linter config

errorlint: 'check for code that could be problematic with the error wrapping scheme'
depguard: to prevent the use of the deprecated 'github.com/pkg/errors'.

I needed to configure depguard and discovered that the config of cgi which handles import ordering is broken, so had to fix it.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2024
errorlint: 'check for code that could be problematic with the error wrapping scheme'
depguard: to prevent the use of the deprecated 'github.com/pkg/errors'.
@jan--f
Copy link
Contributor

jan--f commented Jan 12, 2024

Thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7ffd018 into openshift:master Jan 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants