Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1289: Move vSphere prometheus rules to cluster-storage-operator #2235

Merged
merged 2 commits into from Jan 25, 2024
Merged

STOR-1289: Move vSphere prometheus rules to cluster-storage-operator #2235

merged 2 commits into from Jan 25, 2024

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Jan 16, 2024 •
edited

Move rules that are used to sanitize OCP metric for telemetry to cluster-storage-operator. These rules are used only for storage metrics and should live with storage code.

cluster-storage-operator PR that adds the rules: openshift/cluster-storage-operator#442

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2024 •
edited by openshift-ci bot

@jsafrane: This pull request references STOR-1289 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Move rules that are used to sanitize OCP metric for telemetry to cluster-storage-operator. These rules are used only for storage metrics and should live with storage code.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane jsafrane mentioned this pull request Jan 16, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2024 •
edited by openshift-ci bot

@jsafrane: This pull request references STOR-1289 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Move rules that are used to sanitize OCP metric for telemetry to cluster-storage-operator. These rules are used only for storage metrics and should live with storage code.

cluster-storage-operator PR that adds the rules: openshift/cluster-storage-operator#442

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Move vSphere prometheus rules to cluster-storage-operator
c085b67 
Move rules that are used to sanitize OCP metric for telemetry to
cluster-storage-operator. These rules are used only for storage
metrics and should live with storage code.
@jsafrane
Copy link
Contributor Author

/hold
to coordinate merge with openshift/cluster-storage-operator#442

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2024
@jsafrane
Copy link
Contributor Author

/retest-required

@RomanBednar
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@jan--f
Copy link
Contributor

jan--f commented Jan 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@jsafrane
Copy link
Contributor Author

/px-approved
/docs-approved
This change is not facing users.

@jsafrane
Copy link
Contributor Author

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jan 18, 2024
@jsafrane
Remove vsphere_csi_migration from telemetry
bbf8209 
The source metric (vsphere_csi_migration) was removed in 4.14.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@jsafrane
Copy link
Contributor Author

I'm also removing cluster:vsphere_csi_migration:max from telemetry configuration, that metric was available only in 4.13.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node bbf8209 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RomanBednar
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, jsafrane, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chao007
Copy link

chao007 commented Jan 25, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2024 •
edited by openshift-ci bot

@jsafrane: This pull request references STOR-1289 which is a valid jira issue.

In response to this:

Move rules that are used to sanitize OCP metric for telemetry to cluster-storage-operator. These rules are used only for storage metrics and should live with storage code.

cluster-storage-operator PR that adds the rules: openshift/cluster-storage-operator#442

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2ca7067 and 2 for PR HEAD bbf8209 in total

@openshift-merge-bot openshift-merge-bot bot merged commit e922d0b into openshift:master Jan 25, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees

@jan--f jan--f

@RomanBednar RomanBednar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsafrane @openshift-ci-robot @RomanBednar @jan--f @chao007